Issue 6816061: Add CacheGrind support to grinder coverage mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6816061: Add CacheGrind support to grinder coverage mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by chrisha

Modified:
11 years, 6 months ago

Reviewers:
Roger McFarlane, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add CacheGrind support to grinder coverage mode. This CL also cleans up the command-lines across the instrument and grinder tools, making them consistent. BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=1210

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Addressed siggi's nits. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -90 lines)			Patch
M	syzygy/grinder/coverage_grinder.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	syzygy/grinder/coverage_grinder.cc	View	1	3 chunks	+34 lines, -5 lines	0 comments	Download
M	syzygy/grinder/coverage_grinder_unittest.cc	View	1	3 chunks	+45 lines, -26 lines	0 comments	Download
M	syzygy/grinder/grinder_app.cc	View		3 chunks	+14 lines, -8 lines	0 comments	Download
M	syzygy/grinder/grinder_app_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	syzygy/instrument/instrument.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	syzygy/instrument/instrument_app.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	syzygy/instrument/instrument_app.cc	View		10 chunks	+23 lines, -23 lines	0 comments	Download
M	syzygy/instrument/instrument_app_unittest.cc	View		12 chunks	+18 lines, -18 lines	0 comments	Download
M	syzygy/test_data/test_data.gyp	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Siggi

lgtm with a couple of nits - sweet! https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grinder.cc File syzygy/grinder/coverage_grinder.cc (right): https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grinder.cc#newcode47 syzygy/grinder/coverage_grinder.cc:47: // ...

11 years, 6 months ago (2012-10-30 21:22:31 UTC) #2

chrisha

11 years, 6 months ago (2012-10-31 14:21:17 UTC) #3

Thanks, committing!

https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grin...
File syzygy/grinder/coverage_grinder.cc (right):

https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grin...
syzygy/grinder/coverage_grinder.cc:47: // If the switch isn't prsent we have
nothing to do!
On 2012/10/30 21:22:31, Siggi wrote:
> nit: prsent->present

Done.

https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grin...
File syzygy/grinder/coverage_grinder_unittest.cc (right):

https://codereview.appspot.com/6816061/diff/2001/syzygy/grinder/coverage_grin...
syzygy/grinder/coverage_grinder_unittest.cc:125: TEST_F(CoverageGrinderTest,
GrindAndOutputCacheGrindDataSucceeds) {
On 2012/10/30 21:22:31, Siggi wrote:
> nit: fold the repetition into a member function on the fixture?

Done.

Expand All Messages | Collapse All Messages