Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1376)

Issue 6816059: Revert r6051, re-adding json to DEPS file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by epoger
Modified:
11 years, 11 months ago
Reviewers:
EricB, DerekS
CC:
skia-review_googlegroups.com, DerekS
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Revert r6051, re-adding json to DEPS file Committed: https://code.google.com/p/skia/source/detail?r=6202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
epoger
Reverts https://code.google.com/p/skia/source/detail?r=6051 My understanding was that we removed the json dependency because of https://code.google.com/p/skia/issues/detail?id=949 ('as ...
11 years, 11 months ago (2012-10-30 15:37:36 UTC) #1
epoger
P.S. It looks like the sourceforge/jsoncpp problem described in https://code.google.com/p/skia/issues/detail?id=949 has gone away. Maybe Hurricane ...
11 years, 11 months ago (2012-10-30 15:40:10 UTC) #2
EricB
I believe that the code using JSON was experimental or was using a different copy. ...
11 years, 11 months ago (2012-10-30 15:40:44 UTC) #3
epoger
On 2012/10/30 15:40:44, EricB wrote: > I believe that the code using JSON was experimental ...
11 years, 11 months ago (2012-10-30 15:45:20 UTC) #4
DerekS
The json dependency is used by some of my experimental code for a skia document ...
11 years, 11 months ago (2012-10-30 16:01:52 UTC) #5
epoger
On 2012/10/30 16:01:52, DerekS wrote: > The json dependency is used by some of my ...
11 years, 11 months ago (2012-10-30 16:03:25 UTC) #6
DerekS
11 years, 11 months ago (2012-10-30 16:04:56 UTC) #7
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b