Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 6815080: gtk3: use different prev/next icons depending on orientation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Daiki Ueno
Modified:
1 year, 5 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

gtk3: use different prev/next icons depending on orientation

Use rotated icons for prev/next buttons on lookup table.

BUG=none

Committed: 2ad1813

Patch Set 1 #

Patch Set 2 : check m_ibus_candidates instead of m_candidates on the initial creation of CandidateArea #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M ui/gtk3/candidatearea.vala View 1 3 chunks +30 lines, -13 lines 0 comments Download

Messages

Total messages: 3
Daiki Ueno
It might be more natural to use ←→ instead of ↑↓ when lookup table is ...
1 year, 5 months ago #1
Peng
lgtm
1 year, 5 months ago #2
Daiki Ueno
1 year, 5 months ago #3
On 2012/11/05 14:21:10, Peng wrote:
> lgtm

Thanks, I modified the CL a bit so that set_candidates won't be called from
set_vertical if candidates are not set.  I'll push it later today if no
objection.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5