Issue 6815080: gtk3: use different prev/next icons depending on orientation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6815080: gtk3: use different prev/next icons depending on orientation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by Daiki Ueno

Modified:
11 years, 5 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

gtk3: use different prev/next icons depending on orientation Use rotated icons for prev/next buttons on lookup table. BUG=none Committed: 2ad1813

Patch Set 1 #

Patch Set 2 : check m_ibus_candidates instead of m_candidates on the initial creation of CandidateArea #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -13 lines)			Patch
	M	ui/gtk3/candidatearea.vala	View	1	3 chunks	+30 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

It might be more natural to use ←→ instead of ↑↓ when lookup table is ...

11 years, 5 months ago (2012-11-05 10:08:08 UTC) #1

Daiki Ueno

11 years, 5 months ago (2012-11-06 01:25:01 UTC) #3

On 2012/11/05 14:21:10, Peng wrote:
> lgtm

Thanks, I modified the CL a bit so that set_candidates won't be called from
set_vertical if candidates are not set.  I'll push it later today if no
objection.

Expand All Messages | Collapse All Messages