Issue 6815074: Make GrGLConfigConversionEffect use GrGLEffectMatrix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6815074: Make GrGLConfigConversionEffect use GrGLEffectMatrix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bsalomon

Modified:
11 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrGLConfigConversionEffect use GrGLEffectMatrix Committed: https://code.google.com/p/skia/source/detail?r=6268

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -13 lines)			Patch
	M	src/gpu/effects/GrConfigConversionEffect.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/gpu/effects/GrConfigConversionEffect.cpp	View		7 chunks	+53 lines, -12 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 1 question about something I find odd. https://codereview.appspot.com/6815074/diff/1/src/gpu/effects/GrConfigConversionEffect.cpp File src/gpu/effects/GrConfigConversionEffect.cpp (right): https://codereview.appspot.com/6815074/diff/1/src/gpu/effects/GrConfigConversionEffect.cpp#newcode92 src/gpu/effects/GrConfigConversionEffect.cpp:92: ...

11 years, 11 months ago (2012-11-02 18:13:16 UTC) #2

bsalomon

11 years, 11 months ago (2012-11-02 18:22:30 UTC) #3

https://codereview.appspot.com/6815074/diff/1/src/gpu/effects/GrConfigConvers...
File src/gpu/effects/GrConfigConversionEffect.cpp (right):

https://codereview.appspot.com/6815074/diff/1/src/gpu/effects/GrConfigConvers...
src/gpu/effects/GrConfigConversionEffect.cpp:92: effect.texture(0));
On 2012/11/02 18:13:16, robertphillips wrote:
> In GrGLBlendEffect we shift 'key' rather than 'matrixKey'. Do we want to do
that
> here?

Sure, it's a bit less code, done.

Expand All Messages | Collapse All Messages