Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 6815061: code review 6815061: cmd/gc: fix inlining bug with local variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by remyoudompheng
Modified:
9 years, 6 months ago
Reviewers:
CC:
rsc, lvd, golang-dev
Visibility:
Public.

Description

cmd/gc: fix inlining bug with local variables. Fixes issue 4323.

Patch Set 1 #

Patch Set 2 : diff -r 93dc7f0e302b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 93dc7f0e302b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d6e11ab78b7d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M src/cmd/gc/inl.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4323.go View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello rsc@golang.org, lvd@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2012-10-31 20:54:28 UTC) #1
rsc
LGTM Thanks! I think I just ran into this yesterday.
9 years, 6 months ago (2012-11-01 17:16:56 UTC) #2
remyoudompheng
9 years, 6 months ago (2012-11-01 17:59:37 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=2da23e50774a ***

cmd/gc: fix inlining bug with local variables.

Fixes issue 4323.

R=rsc, lvd, golang-dev
CC=golang-dev
http://codereview.appspot.com/6815061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b