Add cedilla_compose_seqs table for pt_BR compose keys.

Add cedilla_compose_seqs table for pt_BR compose keys.

[fujiwara, 2012-11-12 08:55:56]

I added a new function ibus_engine_simple_add_table_for_gir() to enable gir
annotation "(array length)".

[Peng, 2012-11-12 18:34:35]

https://codereview.appspot.com/6814119/diff/1/engine/main.vala
File engine/main.vala (right):

https://codereview.appspot.com/6814119/diff/1/engine/main.vala#newcode69
engine/main.vala:69: lang.ascii_ncasecmp("pt_br", "pt_br".length) == 0) {
Could you add more comment about why need it for pt_br? Why all keyboard layouts
need it?

https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h
File src/ibusenginesimple.h (right):

https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h#newcode118
src/ibusenginesimple.h:118: * ibus_engine_simple_add_table_for_gir:
How does gtk_im_context_simple_add_table() support gir? Could you please do some
research. Thanks.

[fujiwara, 2012-11-14 09:08:33]

On 2012/11/12 18:34:35, Peng wrote:
> https://codereview.appspot.com/6814119/diff/1/engine/main.vala
> File engine/main.vala (right):
> 
> https://codereview.appspot.com/6814119/diff/1/engine/main.vala#newcode69
> engine/main.vala:69: lang.ascii_ncasecmp("pt_br", "pt_br".length) == 0) {
> Could you add more comment about why need it for pt_br? Why all keyboard
layouts
> need it?

OK, I added the comment here.

> 
> https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h
> File src/ibusenginesimple.h (right):
> 
>
https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h#newcode118
> src/ibusenginesimple.h:118: * ibus_engine_simple_add_table_for_gir:
> How does gtk_im_context_simple_add_table() support gir? Could you please do
some
> research. Thanks.

In GTK+ add "skip" simply to disable the function in gir:
http://git.gnome.org/browse/gtk+/commit/?h=374e76a19dac87676995356f6daacb10f4...
I think if *_add_table() can be gobject-introspected, the gir annotation needs
to support the format of "(array length=(n_seqs * (max_seq_len + 2)))" but it
might be complicated.
I guess a new API is needed besides gtk_im_context_simple_add_table() for gir.
Since we release ibus_engine_simple_add_table at the first time, it may be good
to change the function arguments but I'm not sure how
gtk_im_context_simple_add_table() will be fixed.

[fujiwara, 2012-11-16 08:41:01]

On 2012/11/14 09:08:33, fujiwara wrote:
> On 2012/11/12 18:34:35, Peng wrote:
> > https://codereview.appspot.com/6814119/diff/1/engine/main.vala
> > File engine/main.vala (right):
> > 
> > https://codereview.appspot.com/6814119/diff/1/engine/main.vala#newcode69
> > engine/main.vala:69: lang.ascii_ncasecmp("pt_br", "pt_br".length) == 0) {
> > Could you add more comment about why need it for pt_br? Why all keyboard
> layouts
> > need it?
> 
> OK, I added the comment here.
> 
> > 
> > https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h
> > File src/ibusenginesimple.h (right):
> > 
> >
>
https://codereview.appspot.com/6814119/diff/1/src/ibusenginesimple.h#newcode118
> > src/ibusenginesimple.h:118: * ibus_engine_simple_add_table_for_gir:
> > How does gtk_im_context_simple_add_table() support gir? Could you please do
> some
> > research. Thanks.
> 
> In GTK+ add "skip" simply to disable the function in gir:
>
http://git.gnome.org/browse/gtk+/commit/?h=374e76a19dac87676995356f6daacb10f4...
> I think if *_add_table() can be gobject-introspected, the gir annotation needs
> to support the format of "(array length=(n_seqs * (max_seq_len + 2)))" but it
> might be complicated.
> I guess a new API is needed besides gtk_im_context_simple_add_table() for gir.
> Since we release ibus_engine_simple_add_table at the first time, it may be
good
> to change the function arguments but I'm not sure how
> gtk_im_context_simple_add_table() will be fixed.

OK, I updated the patch.
I think it now works fine.

[Peng, 2012-11-18 14:45:19]

lgtm