Issue 6814105: Apply intersect rects to earlier clip elements and skip rects when possible.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6814105: Apply intersect rects to earlier clip elements and skip rects when possible. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bsalomon

Modified:
12 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Apply intersect rects to earlier clip elements and skip rects when possible. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6351

Patch Set 2 : Apply intersect rects to earlier clip elements and skip rects when possible. #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -70 lines)			Patch
M	include/core/SkClipStack.h	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1	13 chunks	+94 lines, -69 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Apply intersect rects to earlier clip elements and skip rects when possible. R=robertphillips@google.com

12 years ago (2012-11-08 14:12:11 UTC) #1

robertphillips

LGTM + 1 comment suggestion https://codereview.appspot.com/6814105/diff/2001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.appspot.com/6814105/diff/2001/src/gpu/GrClipMaskManager.cpp#newcode643 src/gpu/GrClipMaskManager.cpp:643: get_current_mask_bounds(maskResultBounds, iter, clipToMaskOffset, &currMaskBounds); ...

12 years ago (2012-11-08 14:29:37 UTC) #3

bsalomon

12 years ago (2012-11-08 14:32:34 UTC) #4

https://codereview.appspot.com/6814105/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/6814105/diff/2001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:643: get_current_mask_bounds(maskResultBounds,
iter, clipToMaskOffset, &currMaskBounds);
On 2012/11/08 14:29:38, robertphillips wrote:
> // Since currMaskBounds is mainly used to reduce the amount of touched pixels
we
> can roundOut here (i.e., we do not have to be precise). However,
currMaskBounds
> will exactly account for any encountered non-AA rects.
> ??

SGTM

Expand All Messages | Collapse All Messages