Issue 6814099: Add Git support to the simple rebaseline tool. Do SVN commands only in an svn checkout.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6814099: Add Git support to the simple rebaseline tool. Do SVN commands only in an svn checkout. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Stephen White

Modified:
12 years, 1 month ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add Git support to the simple rebaseline tool. Do SVN commands only in an svn checkout. Committed: https://code.google.com/p/skia/source/detail?r=6341

Patch Set 2 : Use os.path.join for cross-platform happiness. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tools/rebaseline.py	View	1	2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

LGTM https://codereview.appspot.com/6814099/diff/1/tools/rebaseline.py File tools/rebaseline.py (right): https://codereview.appspot.com/6814099/diff/1/tools/rebaseline.py#newcode46 tools/rebaseline.py:46: is_svn_checkout = os.path.exists("../.svn"); maybe use os.path.join() to make ...

12 years, 1 month ago (2012-11-07 22:26:51 UTC) #2

Stephen White

12 years, 1 month ago (2012-11-07 22:31:55 UTC) #3

On 2012/11/07 22:26:51, epoger wrote:
> LGTM
> 
> https://codereview.appspot.com/6814099/diff/1/tools/rebaseline.py
> File tools/rebaseline.py (right):
> 
> https://codereview.appspot.com/6814099/diff/1/tools/rebaseline.py#newcode46
> tools/rebaseline.py:46: is_svn_checkout = os.path.exists("../.svn");
> maybe use os.path.join() to make this cross-platform?

Good idea.  Done.

Expand All Messages | Collapse All Messages