Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(992)

Issue 6814097: fix some minor maven procedure issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by felix8a
Modified:
1 year, 5 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

- Delete target mvn-deploy. afaik, it has never been used, and it 
doesn't work as written. It'll be easy enough to add back
if we decide some day that our maven artifacts should be at
sonatype instead of google code.

- Add description to target mvn-install.

- Rename -javadocs.jar to -javadoc.jar for consistency with 
previous versions published.

- Note that -precajole.jar is a temporary hack.

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix some minor maven procedure issues #

Patch Set 3 : fix some minor maven procedure issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -52 lines) Patch
M build.xml View 1 2 3 chunks +2 lines, -50 lines 0 comments Download
M tools/copy-for-maven View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9
felix8a
1 year, 5 months ago #1
kpreid2
https://codereview.appspot.com/6814097/diff/1/build.xml File build.xml (right): https://codereview.appspot.com/6814097/diff/1/build.xml#newcode1713 build.xml:1713: <!-- description="Signs and Deploys caja artifacts to the central ...
1 year, 5 months ago #2
felix8a
https://codereview.appspot.com/6814097/diff/1/build.xml File build.xml (right): https://codereview.appspot.com/6814097/diff/1/build.xml#newcode1713 build.xml:1713: <!-- description="Signs and Deploys caja artifacts to the central ...
1 year, 5 months ago #3
kpreid2
https://codereview.appspot.com/6814097/diff/1/build.xml File build.xml (right): https://codereview.appspot.com/6814097/diff/1/build.xml#newcode1713 build.xml:1713: <!-- description="Signs and Deploys caja artifacts to the central ...
1 year, 5 months ago #4
felix8a
On 2012/11/07 01:47:03, kpreid2 wrote: > https://codereview.appspot.com/6814097/diff/1/build.xml > File build.xml (right): > > https://codereview.appspot.com/6814097/diff/1/build.xml#newcode1713 > ...
1 year, 5 months ago #5
kpreid2
On 2012/11/07 09:57:25, felix8a wrote: > On 2012/11/07 01:47:03, kpreid2 wrote: > > Please add ...
1 year, 5 months ago #6
felix8a
On 2012/11/07 17:43:20, kpreid2 wrote: > On 2012/11/07 09:57:25, felix8a wrote: > > On 2012/11/07 ...
1 year, 5 months ago #7
kpreid2
LGTM
1 year, 5 months ago #8
felix8a
1 year, 5 months ago #9
@r5148
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5