Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(897)

Issue 6814067: Replace GrMatrix with SkMatrix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bsalomon
Modified:
12 years, 1 month ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Replace GrMatrix with SkMatrix. Committed: https://code.google.com/p/skia/source/detail?r=6247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -935 lines) Patch
M gm/texdata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 10 chunks +13 lines, -13 lines 0 comments Download
M include/gpu/GrEffectStage.h View 6 chunks +9 lines, -9 lines 0 comments Download
D include/gpu/GrMatrix.h View 1 chunk +0 lines, -19 lines 0 comments Download
M include/gpu/GrPaint.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrTypes.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 21 chunks +28 lines, -28 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawState.h View 13 chunks +19 lines, -19 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D src/gpu/GrMatrix.cpp View 1 chunk +0 lines, -713 lines 0 comments Download
M src/gpu/GrPathUtils.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrRectanizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 7 chunks +39 lines, -39 lines 0 comments Download
M src/gpu/gr_unittests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bsalomon
GrMatrix.cpp defined Gr_clz() so this also replaces occurrences of that function with SkCLZ().
12 years, 1 month ago (2012-11-01 17:29:06 UTC) #1
robertphillips
LGTM - spot checked
12 years, 1 month ago (2012-11-01 17:30:23 UTC) #2
reed1
12 years, 1 month ago (2012-11-01 17:56:36 UTC) #3
more code to use my awesome naming conventions, so lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b