Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 6813117: Update debugger GUI to have profile button & list widget to optionally display times (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The profile action is currently stubbed out (following CLs will add functionality). The filename changes are so the filename will be around to be reloaded later for profiling.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -23 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 4 chunks +9 lines, -2 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 10 chunks +36 lines, -20 lines 0 comments Download
M debugger/QT/SkListWidget.cpp View 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5
robertphillips
12 years, 1 month ago (2012-11-12 19:05:01 UTC) #1
DerekS
how are you planning on profiling? The debugger's version of SkPicture is wildly inefficient and ...
12 years, 1 month ago (2012-11-12 20:12:07 UTC) #2
robertphillips
I have posted the entire debugger profiling CL so you can see all the working ...
12 years, 1 month ago (2012-11-12 20:18:08 UTC) #3
DerekS
LGTM
12 years, 1 month ago (2012-11-12 20:26:35 UTC) #4
robertphillips
12 years, 1 month ago (2012-11-12 20:42:37 UTC) #5
committed as r6385
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b