Update filter tool to handle PNG encoded SkBitmaps

Leon - is this how you converted the skps to have encoded bitmaps? When I re-run it (to convert clipPaths to clipRects where possible) the transparent textures get much darker. Additionally it appears that the initial re-encoding swapped R&B.

[Leon, 2012-11-07 16:29:01]

I actually used bench_pictures with the following patch:
https://codereview.appspot.com/6821092/

I did not notice a substantial difference after running converting. I ran
skdiff, which showed very small differences. Looking at the results of the PNG
encoded SKPs on my mac, I do see that the colors are inverted, but I am not sure
they were not inverted before the conversion. I may have solidified the inverted
versions :(

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp#newcode114
tools/filtermain.cpp:114: static bool EncodeStreamAsPNG(SkWStream* stream, const
SkBitmap& bitmap) {
This name sounds to me like it encodes stream as a PNG, when really what it does
is encode bitmap as a PNG in the stream.

In my change, I used the name encodeBitmap (you correctly capitalized yours) but
perhaps a more descriptive name is PNGEncodeBitmapToStream?

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp#newcode204
tools/filtermain.cpp:204: outPicture.serialize(&outStream, EncodeStreamAsPNG);
Shouldn't this be &EncodeStreamAsPNG?

[robertphillips, 2012-11-07 16:49:42]

I re-ran my experiment using a patched render_pictures and the rerecord flag. I
again get the darkening of the culturalsolutions transparent textures.

[robertphillips, 2012-11-08 13:56:12]

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp#newcode114
tools/filtermain.cpp:114: static bool EncodeStreamAsPNG(SkWStream* stream, const
SkBitmap& bitmap) {
On 2012/11/07 16:29:01, scroggo-work wrote:
> This name sounds to me like it encodes stream as a PNG, when really what it
does
> is encode bitmap as a PNG in the stream.
> 
> In my change, I used the name encodeBitmap (you correctly capitalized yours)
but
> perhaps a more descriptive name is PNGEncodeBitmapToStream?

Done.

https://codereview.appspot.com/6813094/diff/1/tools/filtermain.cpp#newcode204
tools/filtermain.cpp:204: outPicture.serialize(&outStream, EncodeStreamAsPNG);
On 2012/11/07 16:29:01, scroggo-work wrote:
> Shouldn't this be &EncodeStreamAsPNG?

Done. The Windows compiler seemed fine with it.

[Leon, 2012-11-12 15:55:50]

lgtm

[robertphillips, 2012-11-12 18:03:44]

committed as r6379