Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(654)

Issue 6813074: Make bench_pictures output a meaningful config name. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Leon
Modified:
12 years, 1 month ago
Reviewers:
benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make bench_pictures output a meaningful config name. Committed: https://code.google.com/p/skia/source/detail?r=6288

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase. #

Patch Set 3 : Add some text for using rtree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -3 lines) Patch
M tools/PictureBenchmark.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.h View 1 2 8 chunks +33 lines, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 6 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Leon
12 years, 1 month ago (2012-11-01 21:42:24 UTC) #1
benchen
LGTM Thanks Leon. The names are much more meaningful than what I'd come up with. ...
12 years, 1 month ago (2012-11-02 01:19:04 UTC) #2
Leon
https://codereview.appspot.com/6813074/diff/1/tools/PictureRenderer.cpp File tools/PictureRenderer.cpp (right): https://codereview.appspot.com/6813074/diff/1/tools/PictureRenderer.cpp#newcode352 tools/PictureRenderer.cpp:352: name.appendf("%.f%%", fTileWidthPercentage); On 2012/11/02 01:19:04, benchen wrote: > I'm ...
12 years, 1 month ago (2012-11-02 21:51:23 UTC) #3
Leon
12 years, 1 month ago (2012-11-02 21:52:50 UTC) #4
https://codereview.appspot.com/6813074/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6813074/diff/1/tools/PictureRenderer.cpp#newco...
tools/PictureRenderer.cpp:352: name.appendf("%.f%%", fTileWidthPercentage);
On 2012/11/02 21:51:23, scroggo-work wrote:
> On 2012/11/02 01:19:04, benchen wrote:
> > I'm a bit concerned with "%"s in the names as it might screw up something in
> > HTML.
> > But since 1) it should only affect urls and we can escape it, and 2) I don't
> > have better alternatives, I'll say let's try it until we find out we need to
> > change it.
> 
> The good news is, at the moment, we do not use one with a percentage. (I
suppose
> one alternative is that I could say "50/100" instead of "50%".)

Sorry for the awkward response. What I meant to say is that the bots never
actually set a width or height percentage (we currently only use 256x256) so
this path does not get taken.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b