Issue 6812101: Fix texture domain clipping assertion. It is OK to have a degenerate domain.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6812101: Fix texture domain clipping assertion. It is OK to have a degenerate domain. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix texture domain clipping assertion. It is OK to have a degenerate domain. Committed: https://code.google.com/p/skia/source/detail?r=6356

Patch Set 3 : #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	gm/drawbitmaprect.cpp	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
	M	src/gpu/effects/GrTextureDomainEffect.cpp	View	1	1 chunk	+10 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 1 question https://codereview.appspot.com/6812101/diff/5001/src/gpu/effects/GrTextureDomainEffect.cpp File src/gpu/effects/GrTextureDomainEffect.cpp (right): https://codereview.appspot.com/6812101/diff/5001/src/gpu/effects/GrTextureDomainEffect.cpp#newcode138 src/gpu/effects/GrTextureDomainEffect.cpp:138: GrAssert(domain.fTop <= domain.fBottom); We don't ...

12 years, 1 month ago (2012-11-08 16:21:53 UTC) #2

bsalomon

12 years, 1 month ago (2012-11-08 16:22:54 UTC) #3

https://codereview.appspot.com/6812101/diff/5001/src/gpu/effects/GrTextureDom...
File src/gpu/effects/GrTextureDomainEffect.cpp (right):

https://codereview.appspot.com/6812101/diff/5001/src/gpu/effects/GrTextureDom...
src/gpu/effects/GrTextureDomainEffect.cpp:138: GrAssert(domain.fTop <=
domain.fBottom);
On 2012/11/08 16:21:53, robertphillips wrote:
> We don't have a function that does this?

I don't know of any that don't either check or assert empty rectangles.

Expand All Messages | Collapse All Messages