Issue 6812092: Add temporary interfaces in blur and clip to

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6812092: Add temporary interfaces in blur and clip to (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by caryclark1

Modified:
11 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add temporary interfaces in blur and clip to permit testing if it is to our advantage to selectively disable soft clipping and high quality blurs during animations. Committed: https://code.google.com/p/skia/source/detail?r=6328

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -0 lines)			Patch
M	include/core/SkCanvas.h	View	2 chunks	+8 lines, -0 lines	1 comment	Download
M	include/core/SkMaskFilter.h	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	src/core/SkCanvas.cpp	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/core/SkMaskFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

11 years, 8 months ago (2012-11-06 21:26:03 UTC) #2

lgtm w/ comment updates

https://codereview.appspot.com/6812092/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.appspot.com/6812092/diff/1/include/core/SkCanvas.h#newcode367
include/core/SkCanvas.h:367: passed to clipRect or clipPath.
// EXPERIMENTAL -- only used for testing

https://codereview.appspot.com/6812092/diff/1/include/core/SkMaskFilter.h
File include/core/SkMaskFilter.h (right):

https://codereview.appspot.com/6812092/diff/1/include/core/SkMaskFilter.h#new...
include/core/SkMaskFilter.h:87: * quality.
quality .. settings

Expand All Messages | Collapse All Messages