Issue 6812064: Remove GrScalar, replace with SkScalar.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6812064: Remove GrScalar, replace with SkScalar. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove GrScalar, replace with SkScalar. Committed: https://code.google.com/p/skia/source/detail?r=6243

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+354 lines, -420 lines)			Patch
M	gyp/gpu.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/gpu/GrConfig.h	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	include/gpu/GrContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrPoint.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	include/gpu/GrScalar.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	6 chunks	+22 lines, -22 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	6 chunks	+17 lines, -17 lines	0 comments	Download
	src/gpu/GrAAConvexPathRenderer.cpp	View	8 chunks	+18 lines, -18 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	4 chunks	+14 lines, -14 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	9 chunks	+17 lines, -17 lines	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
	src/gpu/GrGpuVertex.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrMatrix.cpp	View	22 chunks	+109 lines, -109 lines	0 comments	Download
M	src/gpu/GrPathUtils.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrPathUtils.cpp	View	10 chunks	+32 lines, -32 lines	0 comments	Download
M	src/gpu/GrSWMaskHelper.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	5 chunks	+25 lines, -25 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/effects/GrTextureStripAtlas.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	src/gpu/gl/GrGLRenderTarget.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	5 chunks	+34 lines, -34 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

This was all done mechanically using find/replace with match case and whole word. I don't ...

12 years, 2 months ago (2012-11-01 13:44:01 UTC) #1

LGTM - spot checked

Expand All Messages | Collapse All Messages