Issue 6812062: Implement SkCondVar for windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6812062: Implement SkCondVar for windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Leon

Modified:
11 years, 6 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Implement SkCondVar for windows. Only works on Vista or later, since it uses condition variables. Committed: https://code.google.com/p/skia/source/detail?r=6225

Patch Set 2 : add comment #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -12 lines)			Patch
M	gyp/utils.gyp	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/utils/SkCondVar.h	View		2 chunks	+26 lines, -3 lines	0 comments	Download
M	src/utils/SkCondVar.cpp	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mtklein

LGTM https://codereview.appspot.com/6812062/diff/1/src/utils/SkCondVar.cpp File src/utils/SkCondVar.cpp (right): https://codereview.appspot.com/6812062/diff/1/src/utils/SkCondVar.cpp#newcode25 src/utils/SkCondVar.cpp:25: DeleteCriticalSection(&fCriticalSection); Can you add // No need to ...

11 years, 6 months ago (2012-10-31 19:20:18 UTC) #2

Leon

11 years, 6 months ago (2012-10-31 19:28:50 UTC) #3

https://codereview.appspot.com/6812062/diff/1/src/utils/SkCondVar.cpp
File src/utils/SkCondVar.cpp (right):

https://codereview.appspot.com/6812062/diff/1/src/utils/SkCondVar.cpp#newcode25
src/utils/SkCondVar.cpp:25: DeleteCriticalSection(&fCriticalSection);
On 2012/10/31 19:20:18, mtklein wrote:
> Can you add // No need to clean up fCondition.
> ?

Done.

Expand All Messages | Collapse All Messages