Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1260)

Issue 6812050: Fix alpha computation for specular lighting filter (GPU path). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Stephen White
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix alpha computation for specular lighting filter (GPU path). Change lighting GM background to show blending. NOTE: This will require new results for the lighting GM. Committed: https://code.google.com/p/skia/source/detail?r=6181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M gm/lighting.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
Stephen White
PTAL
12 years, 1 month ago (2012-10-29 19:29:28 UTC) #1
bsalomon
12 years, 1 month ago (2012-10-29 19:36:32 UTC) #2
On 2012/10/29 19:29:28, Stephen White wrote:
> PTAL

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b