Function::GetScriptOrigin should supply sourceURL when script name is not available.

GetScriptOrigin is used for DevTools instrumentation.

If inspected call-site is inside "eval" then returned script name is "undefined".

This causes:
http://code.google.com/p/chromium/issues/detail?id=159413
https://bugs.webkit.org/show_bug.cgi?id=101334

To fix this problem we can use "nameOrSourceURL" method of script-wrapper.

[eustas, 2012-11-07 12:32:07]

Please take a look at proposed fix.

[Jakob, 2012-11-07 14:25:43]

LGTM except for formatting. I can fix that and land this.

In the future, please upload changes against
https://v8.googlecode.com/svn/branches/bleeding_edge (see
https://code.google.com/p/v8/wiki/UsingGit for instructions). Also, please use
@chromium.org usernames for reviewers.

https://codereview.appspot.com/6811090/diff/1/src/handles.cc
File src/handles.cc (right):

https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode597
src/handles.cc:597: Isolate* isolate = script->GetIsolate();
nit: indentation

https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode607
src/handles.cc:607: NULL, &caught_exception);
nit: indentation

[yangguo, 2012-11-07 14:48:28]

https://codereview.appspot.com/6811090/diff/1/src/handles.cc
File src/handles.cc (right):

https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode596
src/handles.cc:596: Handle<Object> GetScriptNameOrSourceURL(Handle<Script>
script) {
I think handles.cc is the wrong place for this. Why not make this a method of
Script and put it into object.h and object.cc?

[yangguo, 2012-11-07 14:50:04]

On 2012/11/07 14:48:28, yangguo wrote:
> https://codereview.appspot.com/6811090/diff/1/src/handles.cc
> File src/handles.cc (right):
> 
> https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode596
> src/handles.cc:596: Handle<Object> GetScriptNameOrSourceURL(Handle<Script>
> script) {
> I think handles.cc is the wrong place for this. Why not make this a method of
> Script and put it into object.h and object.cc?

On another thought, leaving it in handles.cc is probably alright, given that a
lot of other script-related stuff is there already. LGTM.

[eustas, 2012-11-12 11:48:40]

Hello, Jakob.

Could You land it, please?

Thanks.

[Jakob, 2012-11-12 11:55:23]

Sure. I was waiting for our next push to trunk, which will probably happen
today.

Landing.

[Jakob, 2012-11-12 12:35:04]

On 2012/11/12 11:55:23, Jakob wrote:
> Landing.

Done: https://codereview.chromium.org/11312185/ ->
https://code.google.com/p/v8/source/detail?r=12929