CSS styling for buttons

bin/lint-yuidoc

 #!/usr/bin/env python
 
 import os
 import os.path
 import re
 import sys
 
 # We don't want to build or integrate with a full JS parser; fortunately we
 # comply with our coding style well enough that we can pick out the non-trivial
 # function definitions because they are on a line by themselves and are either
@@ skipping 10 matching lines @@
             name = filter(bool, match.groups())[0]
             yield name, line_number
 
 
 def find_docs(function_name, line_number, boundry, source):
     # Walk backwards from the function declaration to find some yuidoc.  If we
     # hit the previous function declaration ("boundry") before finding one,
     # then there is none.
     in_comment = False
     for current_line_number in range(line_number-1, boundry, -1):
-        source_line = source[current_line_number] 
+        source_line = source[current_line_number]
         if source_line.strip().startswith('*/'):
             in_comment = True
         elif source_line.strip().startswith('/*'):
             in_comment = False
         # If we enter or exit a block while scanning backwards without finding
         # documentation, then there is none to be found.
         if not in_comment and ('{' in source_line or '}' in source_line):
             return False
         # If we find a documentation block, tell the caller that we did.
         if '/**' in source[current_line_number]:
@@ skipping 38 matching lines @@
     return [i for i in seq if i != unwanted]
 
 
 def main():
     # Did we find any lint?
     found_errors = False
     # All of the functions found.
     all_functions = []
     for root, dirs, files in os.walk('app'):
         # Ignore any asset directories.
         dirs[:] = remove('assets', dirs)

[gary.poster, 2012/11/01 15:06:30]

I'd remove the function call and do it locally, once you remove the other use of
the function below.  (I'd also switch to "try: dirs.remove('assets') except
ValueError: pass" but that's just me).

If you like it, do it.

[bac, 2012/11/02 09:06:57]

Done.

         # Ignore the template.js file.
         files[:] = remove('templates.js', files)
+        files = filter(lambda x: x.endswith('.js'), files)

[gary.poster, 2012/11/01 15:06:30]

Without much excitement, I suggest you remove the "remove" function and
consolidate this into one pass through the names.  I'd lean towards the list
comprehension, so I'd replace lines 92 and 93 with

files = [i for i in files if i.endswith('.js') and i != 'templates.js']

As you wish.

[bac, 2012/11/02 09:06:57]

Done.

 
         with open('undocumented') as f:
             undocumented = [tuple(line.split()) for line in f.readlines()]
         for file_name in [os.path.join(root, name) for name in files]:
             functions, missing_documentation, falsely_undocumented = (
                 check_file(file_name, undocumented))
             all_functions.extend(functions)
             for code_location in missing_documentation:
                 print code_location, 'missing yuidoc'
                 found_errors = True
@@ skipping 12 matching lines @@
     print 'Backlog of undocumented functions:', len(undocumented)
     print 'Please do your part to drive the above to zero by documenting '
     print 'functions listed in the "undocumented" file and removing their '
     print 'entries therein.  The people of the future thank you.'
 
     return int(found_errors)
 
 
 if __name__ == '__main__':
     sys.exit(main())