Issue 6810111: Make SkPath cache the result of cheapComputeDirection.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6810111: Make SkPath cache the result of cheapComputeDirection. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make SkPath cache the result of cheapComputeDirection. Committed: https://code.google.com/p/skia/source/detail?r=6394

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+281 lines, -114 lines)			Patch
M	include/core/SkPath.h	View	1 2 3	8 chunks	+29 lines, -29 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 2 3	27 chunks	+101 lines, -17 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/PathTest.cpp	View	1 2 3	20 chunks	+149 lines, -64 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

11 years, 7 months ago (2012-11-12 21:42:32 UTC) #3

I take it back. I will first try to add tests for the degenerate serifs I've
seen, that double back on themselves all along the y-max, but should still be
considered "computable".

Expand All Messages | Collapse All Messages