Issue 6810088: Avoid re-definition of STDC symbols, needed for my ffmpeg work.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6810088: Avoid re-definition of STDC symbols, needed for my ffmpeg work.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by phajdan.jr

Modified:
11 years, 10 months ago

Reviewers:
Stephen White

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/include/

Visibility:
Public.

More Reviews

Description

Avoid re-definition of STDC symbols, needed for my ffmpeg work. See changes to build/common.gypi in https://codereview.chromium.org/11364077/ BUG=118986, 91970

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gpu/GrConfig.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

phajdan.jr

Could you review, and also get this landed and rolled into Chromium? Thanks!

11 years, 10 months ago (2012-11-06 18:27:49 UTC) #1

Stephen White

11 years, 10 months ago (2012-11-06 18:39:18 UTC) #3

On 2012/11/06 18:29:18, Stephen White wrote:
> LGTM.  I'll land it.

Landed as https://code.google.com/p/skia/source/detail?r=6313.  Rietveld won't
let me modify this bug, so you should close it.

Skia rolls happen 1-2 times per day; see robertphillips@ for details.

Expand All Messages | Collapse All Messages