Issue 68040043: Issue 1641:Send Feedback Session Published Email Reminder only to students who has something new to…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68040043: Issue 1641:Send Feedback Session Published Email Reminder only to students who has something new to… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by arnold.koroa

Modified:
10 years, 8 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1641:Send Feedback Session Published Email Reminder only to students who has something new to…

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -15 lines)			Patch
	M	src/main/java/teammates/common/datatransfer/FeedbackResponseAttributes.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/main/java/teammates/logic/core/Emails.java	View		5 chunks	+51 lines, -14 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 8 months ago (2014-02-24 09:32:00 UTC) #1

https://codereview.appspot.com/68040043/diff/1/src/main/java/teammates/logic/...
File src/main/java/teammates/logic/core/Emails.java (right):

https://codereview.appspot.com/68040043/diff/1/src/main/java/teammates/logic/...
src/main/java/teammates/logic/core/Emails.java:520: // received feedback from
somebody else
How about the case where they did not receive anything from someone else but
they have something new to see. e.g. feedback from students to the instructor
was made visible to the whole class.

Expand All Messages | Collapse All Messages