Make the orientation of a texture accessible from and known by GrSurface.

Make the orientation of a texture accessible from and known by GrSurface.

R=robertphillips@google.com
Committed: https://code.google.com/p/skia/source/detail?r=6148

[robertphillips, 2012-10-26 18:38:10]

LGTM + some questions

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget.cpp
File src/gpu/gl/GrGLRenderTarget.cpp (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget....
src/gpu/gl/GrGLRenderTarget.cpp:52: desc.fConfig, desc.fSampleCnt),
indent?

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget....
src/gpu/gl/GrGLRenderTarget.cpp:75: desc.fConfig, desc.fSampleCnt),
indent?

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.cpp
File src/gpu/gl/GrGLTexture.cpp (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.cpp#n...
src/gpu/gl/GrGLTexture.cpp:44: const Desc& textureDesc)
Why are we passing both the textureDesc and the fOrigin?

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.h
File src/gpu/gl/GrGLTexture.h (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.h#new...
src/gpu/gl/GrGLTexture.h:61: bool            fOwnsID;
Should this move up to GrTextureDesc?

[bsalomon, 2012-10-26 18:49:47]

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget.cpp
File src/gpu/gl/GrGLRenderTarget.cpp (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget....
src/gpu/gl/GrGLRenderTarget.cpp:52: desc.fConfig, desc.fSampleCnt),
On 2012/10/26 18:38:10, robertphillips wrote:
> indent?

It's a param to INHERITED() not to MakeDesc().

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLRenderTarget....
src/gpu/gl/GrGLRenderTarget.cpp:75: desc.fConfig, desc.fSampleCnt),
On 2012/10/26 18:38:10, robertphillips wrote:
> indent?

ditto

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.cpp
File src/gpu/gl/GrGLTexture.cpp (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.cpp#n...
src/gpu/gl/GrGLTexture.cpp:44: const Desc& textureDesc)
On 2012/10/26 18:38:10, robertphillips wrote:
> Why are we passing both the textureDesc and the fOrigin?

GrGLTexture::Desc derives from GrTextureDesc. GrTextureDesc doesn't know about
Origin; it's one of the things added by the subclass.

We don't want GrTextureDesc to know about origin because it is a public struct
and we want to control the origin assigned via the private constructors used
internally.

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.h
File src/gpu/gl/GrGLTexture.h (right):

https://codereview.appspot.com/6801044/diff/2001/src/gpu/gl/GrGLTexture.h#new...
src/gpu/gl/GrGLTexture.h:61: bool            fOwnsID;
On 2012/10/26 18:38:10, robertphillips wrote:
> Should this move up to GrTextureDesc?

See answer to other Q... we could give clients the ability to control this but I
think we'd want to think through that a bit more. We'd probably want to have a
kDefault or kBackend to choose whatever the native origin is.