Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(319)

Issue 680042: code review 680042: gc: various map-related bug fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by rsc
Modified:
12 years, 10 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: various map-related bug fixes Fixes issue 687.

Patch Set 1 #

Patch Set 2 : code review 680042: gc: various map-related bug fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -58 lines) Patch
M src/cmd/gc/go.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gc/typecheck.c View 2 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/gc/walk.c View 1 7 chunks +45 lines, -50 lines 0 comments Download
M test/golden.out View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 10 months ago (2010-03-23 01:51:12 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=d5bd89e640ef *** gc: various map-related bug fixes Fixes issue 687. R=ken2 CC=golang-dev ...
12 years, 10 months ago (2010-03-23 01:51:17 UTC) #2
ken3
12 years, 10 months ago (2010-03-23 02:49:04 UTC) #3
LGTM

On 2010/03/23 01:51:17, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=d5bd89e640ef ***
> 
> gc: various map-related bug fixes
> 
> Fixes issue 687.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/680042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b