Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 67910048: Issue 1595:InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due …

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by wulifu20hao
Modified:
10 years, 5 months ago
Reviewers:
arnold.koroa
Visibility:
Public.

Description

Issue 1595:InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due …

Patch Set 1 #

Patch Set 2 : Issue 1595: InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due … #

Total comments: 2

Patch Set 3 : Issue 1595:InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due t… #

Patch Set 4 : Issue 1595:InstructorCourseStudentDetailsEdit: wrong student is edited after page is reloaded due t… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
M src/main/java/teammates/common/util/Const.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/main/java/teammates/common/util/FieldValidator.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorCourseStudentDetailsEditPageAction.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/main/java/teammates/ui/controller/InstructorCourseStudentDetailsEditPageData.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorCourseStudentDetailsEditSaveAction.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorCourseStudentEdit.jsp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/teammates/test/cases/ui/InstructorCourseStudentDetailsEditPageActionTest.java View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/InstructorCourseStudentDetailsEditSaveActionTest.java View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorCourseStudentDetailsEditPageUiTest.java View 1 2 4 chunks +21 lines, -2 lines 0 comments Download
M src/test/java/teammates/test/pageobjects/InstructorCourseStudentDetailsEditPage.java View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 1
arnold.koroa
10 years, 6 months ago (2014-03-12 13:38:18 UTC) #1
https://codereview.appspot.com/67910048/diff/20001/.settings/com.google.appen...
File .settings/com.google.appengine.eclipse.core.prefs (right):

https://codereview.appspot.com/67910048/diff/20001/.settings/com.google.appen...
.settings/com.google.appengine.eclipse.core.prefs:6: gaeLaunchAppInBrowser=true
revert this change in hg

https://codereview.appspot.com/67910048/diff/20001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorCourseStudentEdit.jsp (right):

https://codereview.appspot.com/67910048/diff/20001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorCourseStudentEdit.jsp:13: }
You can do this in the Action. If there's no email conflict just assign newEmail
as the student's email
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b