Issue 6785049: Rename StageKey and related stuff.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6785049: Rename StageKey and related stuff. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Rename StageKey and related stuff. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6130

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -93 lines)			Patch
M	include/gpu/GrBackendEffectFactory.h	View	1	4 chunks	+21 lines, -16 lines	0 comments	Download
M	include/gpu/GrEffect.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkLinearGradient.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkRadialGradient.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkSweepGradient.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLEffect.h	View		6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLEffect.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1	6 chunks	+19 lines, -19 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages