Issue 6784053: Make GrGLGradientEffect derive directly from GrGLEffect.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6784053: Make GrGLGradientEffect derive directly from GrGLEffect. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/branches/gpu_dev/

Visibility:
Public.

More Reviews

Description

Make GrGLGradientEffect derive directly from GrGLEffect. Committed: https://code.google.com/p/skia/source/detail?r=6163

Patch Set 2 : #

Total comments: 4

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+274 lines, -247 lines)			Patch
M	src/effects/gradients/SkGradientShader.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	2 chunks	+9 lines, -7 lines	4 comments	Download
M	src/effects/gradients/SkLinearGradient.cpp	View	2 chunks	+16 lines, -10 lines	0 comments	Download
M	src/effects/gradients/SkRadialGradient.cpp	View	2 chunks	+15 lines, -10 lines	0 comments	Download
M	src/effects/gradients/SkSweepGradient.cpp	View	2 chunks	+15 lines, -10 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	3 chunks	+130 lines, -126 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	3 chunks	+88 lines, -83 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 2 comment suggestions https://codereview.appspot.com/6784053/diff/2001/src/effects/gradients/SkGradientShaderPriv.h File src/effects/gradients/SkGradientShaderPriv.h (right): https://codereview.appspot.com/6784053/diff/2001/src/effects/gradients/SkGradientShaderPriv.h#newcode282 src/effects/gradients/SkGradientShaderPriv.h:282: // Emits the uniform ...

11 years, 8 months ago (2012-10-29 11:57:44 UTC) #2

bsalomon

11 years, 8 months ago (2012-10-29 12:42:58 UTC) #3

https://codereview.appspot.com/6784053/diff/2001/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.appspot.com/6784053/diff/2001/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShaderPriv.h:282: // Emits the uniform used as
the y-coord to texture samples in derived classes. Subclasses call
On 2012/10/29 11:57:44, robertphillips wrote:
> Subclasses call _this method_ from emitCode()?

Made it "Subclasses should call this method from their emitCode()."

https://codereview.appspot.com/6784053/diff/2001/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShaderPriv.h:287: // texture, but for simpler
cases we'll be able to lerp. Subclasses call from emitCode().
On 2012/10/29 11:57:44, robertphillips wrote:
> Same here?

Done.

Expand All Messages | Collapse All Messages