Issue 6783053: Make a bunch of GrGLEffects derive directly from GrGLEffect rather than GrGLLegacyEffect.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6783053: Make a bunch of GrGLEffects derive directly from GrGLEffect rather than GrGLLegacyEffect. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/branches/gpu_dev/

Visibility:
Public.

More Reviews

Description

Make a bunch of GrGLEffects derive directly from GrGLEffect rather than GrGLLegacyEffect. Committed: https://code.google.com/p/skia/source/detail?r=6150

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -91 lines)			Patch
M	src/effects/SkBlendImageFilter.cpp	View	2 chunks	+16 lines, -13 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	3 chunks	+9 lines, -11 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	4 chunks	+28 lines, -26 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	3 chunks	+14 lines, -10 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.cpp	View	2 chunks	+10 lines, -8 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View	3 chunks	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages