Issue 6782137: remove 4444 support (for now) form gm -- not used (afaik) and slows us down

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782137: remove 4444 support (for now) form gm -- not used (afaik) and slows us down (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by reed1

Modified:
12 years ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

remove 4444 support (for now) form gm -- not used (afaik) and slows us down Committed: https://code.google.com/p/skia/source/detail?r=6622

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	gm/gmmain.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

EricB

12 years ago (2012-11-29 21:19:34 UTC) #3

On 2012/11/29 21:15:37, reed1 wrote:
> hmmm, unless I don't need to?

Looks like there are a number of *_4444 images in gm-expected.  It's not
necessary to remove them at this time, and maybe it's worth keeping them around
in case we turn this back on?  LGTM.

Expand All Messages | Collapse All Messages