Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(691)

Issue 6782099: Fix out-of-tree build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by Daiki Ueno
Modified:
12 years ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix out-of-tree build Also cleanup Makefiles and fix build error with older valac. BUG=none

Patch Set 1 #

Patch Set 2 : fix out-of-tree build with --enable-gtk-doc #

Patch Set 3 : removed ibusversion.h from BUILT_SOURCES, since it is generated by configure #

Total comments: 2

Patch Set 4 : fold too long lines, rename introspection make vars according to some gnome modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M bindings/vala/Makefile.am View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/reference/ibus/Makefile.am View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M engine/main.vala View 1 chunk +1 line, -1 line 0 comments Download
M src/Makefile.am View 1 2 3 6 chunks +21 lines, -18 lines 0 comments Download
M src/tests/Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
Daiki Ueno
12 years ago (2012-11-22 22:05:14 UTC) #1
Peng
lgtm https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am File src/Makefile.am (right): https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am#newcode184 src/Makefile.am:184: IBus_1_0_gir_FILES = $(addprefix $(srcdir)/,$(introspection_files)) $(addprefix $(builddir)/,$(introspection_built_files)) More than ...
12 years ago (2012-11-22 22:08:52 UTC) #2
Daiki Ueno
12 years ago (2012-11-23 02:12:58 UTC) #3
https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am
File src/Makefile.am (right):

https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am#newcode184
src/Makefile.am:184: IBus_1_0_gir_FILES = $(addprefix
$(srcdir)/,$(introspection_files)) $(addprefix
$(builddir)/,$(introspection_built_files))
On 2012/11/22 22:08:53, Peng wrote:
> More than 80 chars. 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b