Issue 6782099: Fix out-of-tree build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782099: Fix out-of-tree build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Daiki Ueno

Modified:
11 years, 11 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix out-of-tree build Also cleanup Makefiles and fix build error with older valac. BUG=none

Patch Set 2 : fix out-of-tree build with --enable-gtk-doc #

Patch Set 3 : removed ibusversion.h from BUILT_SOURCES, since it is generated by configure #

Total comments: 2

Patch Set 4 : fold too long lines, rename introspection make vars according to some gnome modules #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -22 lines)			Patch
M	bindings/vala/Makefile.am	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	docs/reference/ibus/Makefile.am	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	engine/main.vala	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/Makefile.am	View	1 2 3	6 chunks	+21 lines, -18 lines	0 comments	Download
M	src/tests/Makefile.am	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am File src/Makefile.am (right): https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am#newcode184 src/Makefile.am:184: IBus_1_0_gir_FILES = $(addprefix $(srcdir)/,$(introspection_files)) $(addprefix $(builddir)/,$(introspection_built_files)) More than ...

11 years, 11 months ago (2012-11-22 22:08:52 UTC) #2

Daiki Ueno

11 years, 11 months ago (2012-11-23 02:12:58 UTC) #3

https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am
File src/Makefile.am (right):

https://codereview.appspot.com/6782099/diff/4001/src/Makefile.am#newcode184
src/Makefile.am:184: IBus_1_0_gir_FILES = $(addprefix
$(srcdir)/,$(introspection_files)) $(addprefix
$(builddir)/,$(introspection_built_files))
On 2012/11/22 22:08:53, Peng wrote:
> More than 80 chars. 

Done.

Expand All Messages | Collapse All Messages