Issue 6780047: code review 6780047: go.crypto/ssh: never negotiate unsupported ciphers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6780047: code review 6780047: go.crypto/ssh: never negotiate unsupported ciphers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by dave

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

go.crypto/ssh: never negotiate unsupported ciphers Fixes issue 4285. Adding a new cipher that is supported by the remote end, but not supported by our client causes that cipher to be considered a valid candidate. This fails later in setupKeys when there is no cipherModes configuration. In summary, unsupported ciphers cannot be willed into existence by adding them to the client config. This change enforces this.

Patch Set 1 #

Patch Set 2 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -29 lines)			Patch
M	ssh/cipher.go	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ssh/client_auth_test.go	View	1 2 3 4 5	1 chunk	+20 lines, -0 lines	0 comments	Download
M	ssh/common.go	View	1 2 3 4	5 chunks	+16 lines, -5 lines	0 comments	Download
M	ssh/test/session_test.go	View	1 2 3 4 5 6	6 chunks	+6 lines, -6 lines	0 comments	Download
M	ssh/test/tcpip_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ssh/test/test_unix_test.go	View	1	5 chunks	+27 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto

13 years, 11 months ago (2012-10-26 08:12:12 UTC) #1

dave_cheney.net

13 years, 11 months ago (2012-10-30 07:14:02 UTC) #4

*** Submitted as
http://code.google.com/p/go/source/detail?r=a2200bbe5d14&repo=crypto ***

go.crypto/ssh: never negotiate unsupported ciphers

Fixes issue 4285.

Adding a new cipher that is supported by the remote end, but not supported by
our client causes that cipher to be considered a valid candidate. This fails
later in setupKeys when there is no cipherModes configuration.

In summary, unsupported ciphers cannot be willed into existence by adding them
to the client config. This change enforces this.

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6780047

Expand All Messages | Collapse All Messages