Issue 6779057: Make GrGLEffect::setData take GrEffectStage rather than GrEffect.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6779057: Make GrGLEffect::setData take GrEffectStage rather than GrEffect. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/branches/gpu_dev/

Visibility:
Public.

More Reviews

Description

Make GrGLEffect::setData take GrEffectStage rather than GrEffect. This allows the coord-change matrix to be communicated to setData(). An accessor for this matrix is also added to GrEffectStage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6143

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -63 lines)			Patch
M	include/gpu/GrEffectStage.h	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View	6 chunks	+14 lines, -13 lines	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkGradientShaderPriv.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLEffect.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLEffect.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

Note that this change is in /branches/gpu_dev not /trunk.

12 years, 1 month ago (2012-10-26 14:24:08 UTC) #1

LGTM

Expand All Messages | Collapse All Messages