Make output path to render_pictures optional

Make output path to render_pictures optional
Committed: https://code.google.com/p/skia/source/detail?r=6136

[Leon, 2012-10-25 19:41:17]

So now if you call

PictureRenderer->render(NULL)

it will always return true? Can you update comment in the header?

https://codereview.appspot.com/6779049/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (left):

https://codereview.appspot.com/6779049/diff/1/tools/PictureRenderer.cpp#oldco...
tools/PictureRenderer.cpp:387: break;
Why is this being removed? The goal in quitting now is that (in my mind) there's
no reason to continue drawing tiles if we already determined it was a failure.

https://codereview.appspot.com/6779049/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6779049/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:114: if (outputDir) {
Style guide prefers comparing to NULL. i.e.

if (outputDir != NULL)

There are a few other instances as well.

[EricB, 2012-10-25 19:51:57]

Patch set 2 changes the comment in PictureRenderer.h.

https://codereview.appspot.com/6779049/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (left):

https://codereview.appspot.com/6779049/diff/1/tools/PictureRenderer.cpp#oldco...
tools/PictureRenderer.cpp:387: break;
On 2012/10/25 19:41:17, scroggo-work wrote:
> Why is this being removed? The goal in quitting now is that (in my mind)
there's
> no reason to continue drawing tiles if we already determined it was a failure.

Good point.  I guess my motivation was to collect all the images that could be
successfully rendered, even if one or more failed.  I changed it back so that
the logic is the same.

https://codereview.appspot.com/6779049/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6779049/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:114: if (outputDir) {
On 2012/10/25 19:41:17, scroggo-work wrote:
> Style guide prefers comparing to NULL. i.e.
> 
> if (outputDir != NULL)
> 
> There are a few other instances as well.

Fixed here and elsewhere.

[Leon, 2012-10-25 20:05:34]

lgtm