Issue 6779043: Fix decl of gl_FragCoord in GLSL versions <= 1.20.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6779043: Fix decl of gl_FragCoord in GLSL versions <= 1.20. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix decl of gl_FragCoord in GLSL versions <= 1.20. We we're saying "in" instead of "varying". Committed: https://code.google.com/p/skia/source/detail?r=6104

Patch Set 1 #

Total comments: 4

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
	M	src/gpu/gl/GrGLShaderBuilder.cpp	View		1 chunk	+6 lines, -1 line	2 comments	Download
	M	src/gpu/gl/GrGLShaderVar.h	View		14 chunks	+35 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 2 questions https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp File src/gpu/gl/GrGLShaderBuilder.cpp (right): https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp#newcode291 src/gpu/gl/GrGLShaderBuilder.cpp:291: fFSHeader.append("#extension GL_ARB_fragment_coord_conventions: require\n"); Is this ...

12 years, 1 month ago (2012-10-25 14:51:28 UTC) #2

bsalomon

12 years, 1 month ago (2012-10-25 14:59:40 UTC) #3

https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderBuilder.cp...
src/gpu/gl/GrGLShaderBuilder.cpp:291: fFSHeader.append("#extension
GL_ARB_fragment_coord_conventions: require\n");
On 2012/10/25 14:51:29, robertphillips wrote:
> Is this variable used anywhere?

whoops... at first I was creating and then appending. Removed.

https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderVar.h
File src/gpu/gl/GrGLShaderVar.h (right):

https://codereview.appspot.com/6779043/diff/1/src/gpu/gl/GrGLShaderVar.h#newc...
src/gpu/gl/GrGLShaderVar.h:51: kDefault_Origin,        // when set to kDefault
the origin field is ignored.
On 2012/10/25 14:51:29, robertphillips wrote:
> use -> used?

Done.

Expand All Messages | Collapse All Messages