Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2282)

Issue 6777053: Rename GrSamplerState to GrEffectStage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by bsalomon
Modified:
11 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Rename GrSamplerState to GrEffectStage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6135

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -423 lines) Patch
M gm/texdata.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
A + include/gpu/GrEffectStage.h View 3 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/GrPaint.h View 1 2 9 chunks +24 lines, -28 lines 0 comments Download
D include/gpu/GrSamplerState.h View 1 1 chunk +0 lines, -147 lines 0 comments Download
M src/core/SkShader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 9 chunks +15 lines, -19 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 12 chunks +34 lines, -33 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 15 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 7 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 5 chunks +21 lines, -21 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2
bsalomon
This... is... almost... over... I renamed some integer index params from "stage" to "stageIdx" since ...
11 years, 8 months ago (2012-10-25 22:05:33 UTC) #1
robertphillips
11 years, 8 months ago (2012-10-26 12:09:13 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b