Issue 6777051: [PDF] Improve complex xfer mode support.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6777051: [PDF] Improve complex xfer mode support.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by edisonn

Modified:
13 years, 2 months ago

Reviewers:
Chris Guillory, Steve VanDeBogart

CC:
skia-review_googlegroups.com, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This change was implemented by Steve, I am just checking it in, along with testing it. [PDF] Improve complex xfer mode support. Xfer mode applies only to the shape of the source drawing, not everything in the clip as in currently implemented. It's just that the current gm examples draw a shape that fills the visible layer. It improves 5 gms slightly, see attached src_improve.zip at http://code.google.com/p/skia/issues/detail?id=943

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -100 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		7 chunks	+162 lines, -95 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Steve VanDeBogart

13 years, 2 months ago (2012-10-25 21:15:41 UTC) #2

I'd suggest trying to bring back r1705 first (it was reverted).  It clearly
demonstrates/tests the improvements made by this change.

Is this a straight import of patch set two of
https://codereview.appspot.com/4631078 ?  Did it need to be rebased?  Have you
reviewed/come to understand the CL?  If not, I'm just reviewing my own code and
that's not what we want.

Expand All Messages | Collapse All Messages