Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(933)

Issue 6776043: code review 6776043: crypto/tls: add support for loading EC X.509 key pairs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by jsing
Modified:
10 years ago
Reviewers:
CC:
agl1, golang-dev
Visibility:
Public.

Description

crypto/tls: add support for loading EC X.509 key pairs Add support for loading X.509 key pairs that consist of a certificate with an EC public key and its corresponding EC private key.

Patch Set 1 : diff -r d9896259d8e5 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r d9896259d8e5 https://go.googlecode.com/hg/ #

Total comments: 12

Patch Set 3 : diff -r 15a03e58cd8d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 659f7a1810dd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -31 lines) Patch
M src/pkg/crypto/tls/tls.go View 1 2 3 3 chunks +52 lines, -20 lines 0 comments Download
M src/pkg/crypto/tls/tls_test.go View 1 2 3 chunks +57 lines, -11 lines 0 comments Download

Messages

Total messages: 5
jsing
Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years ago (2012-11-14 14:18:52 UTC) #1
agl1
https://codereview.appspot.com/6776043/diff/8001/src/pkg/crypto/tls/tls.go File src/pkg/crypto/tls/tls.go (right): https://codereview.appspot.com/6776043/diff/8001/src/pkg/crypto/tls/tls.go#newcode158 src/pkg/crypto/tls/tls.go:158: if strings.HasSuffix(keyDERBlock.Type, "PRIVATE KEY") { " PRIVATE KEY" https://codereview.appspot.com/6776043/diff/8001/src/pkg/crypto/tls/tls.go#newcode175 ...
10 years ago (2012-11-14 16:32:59 UTC) #2
jsing
PTAL https://codereview.appspot.com/6776043/diff/8001/src/pkg/crypto/tls/tls.go File src/pkg/crypto/tls/tls.go (right): https://codereview.appspot.com/6776043/diff/8001/src/pkg/crypto/tls/tls.go#newcode158 src/pkg/crypto/tls/tls.go:158: if strings.HasSuffix(keyDERBlock.Type, "PRIVATE KEY") { On 2012/11/14 16:32:59, ...
10 years ago (2012-11-15 14:03:37 UTC) #3
agl1
LGTM
10 years ago (2012-11-15 17:57:29 UTC) #4
jsing
10 years ago (2012-11-16 08:40:46 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f440e65f93fe ***

crypto/tls: add support for loading EC X.509 key pairs

Add support for loading X.509 key pairs that consist of a certificate
with an EC public key and its corresponding EC private key.

R=agl
CC=golang-dev
http://codereview.appspot.com/6776043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b