Issue 6775100: Remove default texture coords / texture matrix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6775100: Remove default texture coords / texture matrix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove default texture coords / texture matrix Committed: https://code.google.com/p/skia/source/detail?r=6293

Patch Set 5 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -360 lines)			Patch
M	include/gpu/GrEffectStage.h	View	1	4 chunks	+1 line, -26 lines	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLEffect.h	View		3 chunks	+4 lines, -12 lines	0 comments	Download
M	src/gpu/gl/GrGLEffect.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View	1 2 3 4	7 chunks	+4 lines, -36 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1 2 3	10 chunks	+8 lines, -58 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View		3 chunks	+5 lines, -28 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		1 chunk	+2 lines, -32 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		3 chunks	+4 lines, -110 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View		4 chunks	+7 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 1 question https://codereview.appspot.com/6775100/diff/6001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): https://codereview.appspot.com/6775100/diff/6001/src/gpu/gl/GrGLProgram.cpp#newcode598 src/gpu/gl/GrGLProgram.cpp:598: for (int s = 0; ...

12 years, 1 month ago (2012-11-05 15:00:49 UTC) #2

bsalomon

12 years, 1 month ago (2012-11-05 16:10:39 UTC) #3

https://codereview.appspot.com/6775100/diff/6001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.appspot.com/6775100/diff/6001/src/gpu/gl/GrGLProgram.cpp#n...
src/gpu/gl/GrGLProgram.cpp:598: for (int s = 0; s < fDesc.fFirstCoverageStage;
++s) {
On 2012/11/05 15:00:49, robertphillips wrote:
> Should there be something more to this test? 0 ==?
Yeah, I'll make an enum value for it, kNoEffectKey, defined where EffectKey is
defined.

Expand All Messages | Collapse All Messages