Issue 6775097: Fix some build warnings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6775097: Fix some build warnings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by Peng

Modified:
11 years, 5 months ago

Reviewers:
fujiwara

Base URL:
git@github.com:/ibus/ibus@master

Visibility:
Public.

More Reviews

Description

Fix some build warnings. BUG=None Committed: ebfb9ae

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -17 lines)			Patch
M	bus/dbusimpl.c	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/main.vala	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ui/gtk3/candidatearea.vala	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	ui/gtk3/candidatepanel.vala	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/gtk3/keybindingmanager.vala	View	2 chunks	+4 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

lgtm with a review. https://codereview.appspot.com/6775097/diff/1/ui/gtk3/keybindingmanager.vala File ui/gtk3/keybindingmanager.vala (right): https://codereview.appspot.com/6775097/diff/1/ui/gtk3/keybindingmanager.vala#newcode231 ui/gtk3/keybindingmanager.vala:231: foreach (var mask in masks) ...

11 years, 5 months ago (2012-11-05 05:26:06 UTC) #2

Peng

11 years, 5 months ago (2012-11-05 15:12:44 UTC) #3

https://codereview.appspot.com/6775097/diff/1/ui/gtk3/keybindingmanager.vala
File ui/gtk3/keybindingmanager.vala (right):

https://codereview.appspot.com/6775097/diff/1/ui/gtk3/keybindingmanager.vala#...
ui/gtk3/keybindingmanager.vala:231: foreach (var mask in masks) {
On 2012/11/05 05:26:06, fujiwara wrote:
> This also can be fixed.
This one is not necessary. Because masks[] is not a const value. Only const
array has the problem. Because vala does not generate code for const array
correctly. :(

Expand All Messages | Collapse All Messages