Adding rtree support to the bench_pictures utility

Adding rtree support to the bench_pictures utility
Committed: https://code.google.com/p/skia/source/detail?r=6267

[junov1, 2012-11-01 22:02:32]

PTAL

[benchen, 2012-11-02 01:04:43]

Although this looks good to me, it may be because I'm still learning on the
details. Please wait for Leon's LG. Thanks.

[Leon, 2012-11-02 17:39:57]

What do you think about rerecording the picture in PictureBenchmark? Then we can
leave each separate renderer (including future renderers) unchanged.

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:97: this->recordFlags());
should line up with the open parens.

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:169: SkCanvas* recorder =
replayer->beginRecording(fPicture->width(), fPicture->height(),
this->recordFlags());
100 columns

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:559: SkCanvas* recorder =
fReplayer->beginRecording(fPicture->width(), fPicture->height(),
this->recordFlags());
100 columns

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:574: virtual SkBBoxHierarchy* createBBoxHierarchy()
const SK_OVERRIDE{
This looks to be the same as in SkPicture. Is it duplicated here in case the
original changes?

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:586: case kNone_BBoxHierarchyType:
case should be indented from switch.

[junov1, 2012-11-02 17:55:12]

On 2012/11/02 17:39:57, scroggo-work wrote:
> What do you think about rerecording the picture in PictureBenchmark? Then we
can
> leave each separate renderer (including future renderers) unchanged.

I disagree because different renderers use the rtree in different ways.  For the
simple and tiled renderers, it is just a matter of rerecording, but for the
recording and playbackConversion renderers, it is matter of using a temp picture
that has a BBoxHierarchy.  Also, by putting this in PictureRenderer, it is
available to more test utils, which will come in handy very soon.

https://codereview.appspot.com/6775080/diff/2001/tools/PictureRenderer.cpp#ne...
> tools/PictureRenderer.cpp:574: virtual SkBBoxHierarchy* createBBoxHierarchy()
> const SK_OVERRIDE{
> This looks to be the same as in SkPicture. Is it duplicated here in case the
> original changes?

Exactly. When a test program explicitly chooses RTree, we have to use an RTree. 
Soon SkPicture will have some selection logic that may make it chose an
alternate acceleration structure.

[junov1, 2012-11-02 17:58:44]

patch

[Leon, 2012-11-02 18:02:34]

On 2012/11/02 17:58:44, junov1 wrote:
> patch

lgtm