Fix Issue 1893 "uriPolicy.mitigate() does not actually prevent mitigation"

Problem reported and fix suggested by James Keane at 
https://code.google.com/p/google-caja/issues/detail?id=1893
I probably forgot to add rewriteFunctionCalls to this list when I
added it as another mitigation option.

[kpreid_google, 2014-02-24 18:09:05]

Because this is a third party patch, James Keane needs to sign the CLA at
<https://developers.google.com/open-source/cla/individual>.

[MarkM, 2014-03-11 23:24:47]

CLA at https://code.google.com/p/google-caja/issues/detail?id=1893#c4

[MarkM, 2014-03-11 23:25:56]

On 2014/03/11 23:24:47, MarkM wrote:
> CLA at https://code.google.com/p/google-caja/issues/detail?id=1893#c4

Actually at https://dl.dropboxusercontent.com/u/238038461/Wishabi-Google.CLA.pdf

[kpreid_google, 2014-03-11 23:31:21]

LGTM

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
File src/com/google/caja/plugin/html-emitter.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
src/com/google/caja/plugin/html-emitter.js:593: rewriteFunctionCalls: false
Please write the properties either in alphabetical order or the order in which
their documentation lists them, or other consistent and non-arbitrary order.

Also, consistent whitespace (no space before colon in any line).

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
src/com/google/caja/ses/startSES.js:784: // coordination with the list of
mitigation options in
Insofar as SES should be able to hypothetically exist as a separate library
which Caja depends on, it would be nice if such coordination were somehow not
necessary.

[MarkM, 2014-03-12 00:03:15]

Problem reported and fix suggested by James Keane at 
https://code.google.com/p/google-caja/issues/detail?id=1893
I probably forgot to add rewriteFunctionCalls to this list when I
added it as another mitigation option.

[MarkM, 2014-03-12 00:04:53]

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
File src/com/google/caja/plugin/html-emitter.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
src/com/google/caja/plugin/html-emitter.js:593: rewriteFunctionCalls: false
On 2014/03/11 23:31:21, kpreid_google wrote:
> Please write the properties either in alphabetical order or the order in which
> their documentation lists them, or other consistent and non-arbitrary order.
> 
> Also, consistent whitespace (no space before colon in any line).

Done. I chose the order of the documentation on prepareExpr. While there, I also
noticed that "parseProgram" is now called "parseFunctionBody", so I changed that
too. PTAL in case I shouldn't be disabling that here.

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
src/com/google/caja/ses/startSES.js:784: // coordination with the list of
mitigation options in
On 2014/03/11 23:31:21, kpreid_google wrote:
> Insofar as SES should be able to hypothetically exist as a separate library
> which Caja depends on, it would be nice if such coordination were somehow not
> necessary.

I agree. Suggestions?

[kpreid_google, 2014-03-12 00:11:19]

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
File src/com/google/caja/plugin/html-emitter.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
src/com/google/caja/plugin/html-emitter.js:593: rewriteFunctionCalls: false
On 2014/03/12 00:04:53, MarkM wrote:
> While there, I also noticed
> that "parseProgram" is now called "parseFunctionBody", so I changed that
> too. PTAL in case I shouldn't be disabling that here.

I do not grok mitigation. If you need verification of that, request review from
someone who does.

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
src/com/google/caja/ses/startSES.js:784: // coordination with the list of
mitigation options in
On 2014/03/12 00:04:53, MarkM wrote:
> On 2014/03/11 23:31:21, kpreid_google wrote:
> > Insofar as SES should be able to hypothetically exist as a separate library
> > which Caja depends on, it would be nice if such coordination were somehow
> > not necessary.
> 
> I agree. Suggestions?

Well, from the perspective of the dependencies, evaluateUntrustedExternalScript
does what it does because it wants to avoid mitigation on the premise that it
has content which either is already rewritten or doesn't care. On those grounds
the rewriter-or-not-carer should be supplying the relevant options.

More practically, we could have SES export an appropriate options structure for
the no-mitigation goal, which evaluateUntrustedExternalScript then passes back
in.

[MarkM, 2014-03-12 05:49:21]

On 2014/03/12 00:11:19, kpreid_google wrote:
>
https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
> File src/com/google/caja/plugin/html-emitter.js (right):
> 
>
https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/plugin/htm...
> src/com/google/caja/plugin/html-emitter.js:593: rewriteFunctionCalls: false
> On 2014/03/12 00:04:53, MarkM wrote:
> > While there, I also noticed
> > that "parseProgram" is now called "parseFunctionBody", so I changed that
> > too. PTAL in case I shouldn't be disabling that here.
> 
> I do not grok mitigation. If you need verification of that, request review
from
> someone who does.

Who do you suggest?

> 
>
https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
> File src/com/google/caja/ses/startSES.js (right):
> 
>
https://codereview.appspot.com/67720043/diff/1/src/com/google/caja/ses/startS...
> src/com/google/caja/ses/startSES.js:784: // coordination with the list of
> mitigation options in
> On 2014/03/12 00:04:53, MarkM wrote:
> > On 2014/03/11 23:31:21, kpreid_google wrote:
> > > Insofar as SES should be able to hypothetically exist as a separate
library
> > > which Caja depends on, it would be nice if such coordination were somehow
> > > not necessary.
> > 
> > I agree. Suggestions?
> 
> Well, from the perspective of the dependencies,
evaluateUntrustedExternalScript
> does what it does because it wants to avoid mitigation on the premise that it
> has content which either is already rewritten or doesn't care. On those
grounds
> the rewriter-or-not-carer should be supplying the relevant options.
> 
> More practically, we could have SES export an appropriate options structure
for
> the no-mitigation goal, which evaluateUntrustedExternalScript then passes back
> in.

[kpreid_google, 2014-03-12 16:29:07]

On 2014/03/12 05:49:21, MarkM wrote:
> On 2014/03/12 00:11:19, kpreid_google wrote:
> > I do not grok mitigation. If you need verification of that, request review
> > from someone who does.
> 
> Who do you suggest?

Jasvir or Ihab?

[MarkM, 2014-03-13 16:26:11]

Mike, Jas, Ihab, can you take a look at the mitigation issue to be sure these
changes result in a safe state? Thanks.

[Jasvir, 2014-03-16 00:31:04]

+1 although in the absence of a compiler that checks the enum, it would help
defend against future errors/misspellings/option renames if mitigateOpts was
checked for unexpected own keys.

[MarkM, 2014-03-16 22:19:01]

Filed https://code.google.com/p/google-caja/issues/detail?id=1904 to keep track
of good suggestions not implemented by this CL.

[MarkM, 2014-03-16 22:23:19]

After a "myvn up", I get the following. The "myvn up" did update a bunch of
third_party/java/appengine/* stuff. What's the problem here, and what
should I do to get past it?



$ ant clean

Buildfile: /Users/erights/svn-changes/unrepair/google-caja/build.xml


BUILD FAILED

/Users/erights/svn-changes/unrepair/google-caja/build.xml:125: The
following error occurred while executing this line:

/Users/erights/svn-changes/unrepair/google-caja/third_party/java/appengine/config/user/ant-macros.xml:83:
java.lang.UnsupportedClassVersionError:
com/google/appengine/tools/enhancer/EnhancerTask : Unsupported major.minor
version 51.0

at java.lang.ClassLoader.defineClass1(Native Method)

at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)

at java.lang.ClassLoader.defineClass(ClassLoader.java:621)

at
org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1128)

at
org.apache.tools.ant.AntClassLoader.getClassFromStream(AntClassLoader.java:1299)

at
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1354)

at org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1315)

at org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1068)

at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

at java.lang.Class.forName0(Native Method)

at java.lang.Class.forName(Class.java:249)

at org.apache.tools.ant.taskdefs.Definer.addDefinition(Definer.java:579)

at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:237)

at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)

at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)

at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)

at org.apache.tools.ant.Task.perform(Task.java:348)

at org.apache.tools.ant.Target.execute(Target.java:435)

at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:168)

at
org.apache.tools.ant.taskdefs.ImportTask.importResource(ImportTask.java:230)

at org.apache.tools.ant.taskdefs.ImportTask.execute(ImportTask.java:162)

at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)

at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)

at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)

at org.apache.tools.ant.Task.perform(Task.java:348)

at org.apache.tools.ant.Target.execute(Target.java:435)

at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:179)

at
org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:93)

at org.apache.tools.ant.Main.runBuild(Main.java:826)

at org.apache.tools.ant.Main.startAnt(Main.java:235)

at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)

at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)


Total time: 0 seconds

[MarkM, 2014-03-16 22:24:08]

The "myvn up" log:

$ myvn up

Updating '.':

U    src/com/google/caja/lang/html/html5-attributes-whitelist.json

U    src/com/google/caja/lang/html/html5-attributes-defs.json

D    third_party/java/appengine/docs

D    third_party/java/appengine/RELEASE_NOTES.ORM

A    third_party/java/appengine/RELEASE_NOTES.ORM

D    third_party/java/appengine/config

A    third_party/java/appengine/config

A    third_party/java/appengine/config/sdk

A    third_party/java/appengine/config/sdk/logging.properties

A    third_party/java/appengine/config/user

A    third_party/java/appengine/config/user/logging.properties

A    third_party/java/appengine/config/user/ant-macros.xml

A    third_party/java/appengine/config/user/log4j.properties

D    third_party/java/appengine/lib

A    third_party/java/appengine/lib

A    third_party/java/appengine/lib/override

A    third_party/java/appengine/lib/override/appengine-dev-jdk-overrides.jar

A    third_party/java/appengine/lib/tools

A    third_party/java/appengine/lib/tools/jsp

A
third_party/java/appengine/lib/tools/jsp/repackaged-appengine-jasper-jdt-6.0.29.jar

A    third_party/java/appengine/lib/tools/jsp/LICENSE

A
third_party/java/appengine/lib/tools/jsp/repackaged-appengine-jakarta-jstl-1.1.2.jar

A
third_party/java/appengine/lib/tools/jsp/repackaged-appengine-jakarta-standard-1.1.2.jar

A    third_party/java/appengine/lib/tools/orm

A    third_party/java/appengine/lib/tools/orm/datanucleus-enhancer-1.1.4.jar

A    third_party/java/appengine/lib/tools/orm/jdo2-api-2.3-eb.jar

A
third_party/java/appengine/lib/tools/orm/geronimo-jpa_3.0_spec-1.1.1.jar

A    third_party/java/appengine/lib/tools/orm/datanucleus-core-1.1.5.jar

A
third_party/java/appengine/lib/tools/orm/geronimo-jta_1.1_spec-1.1.1.jar

A    third_party/java/appengine/lib/tools/orm/datanucleus-jpa-1.1.5.jar

A    third_party/java/appengine/lib/tools/orm/asm-4.1.jar

A    third_party/java/appengine/lib/impl

A    third_party/java/appengine/lib/impl/appengine-api-stubs.jar

A    third_party/java/appengine/lib/impl/google_sql.jar

A    third_party/java/appengine/lib/impl/appengine-api-labs.jar

A    third_party/java/appengine/lib/impl/appengine-api.jar

A    third_party/java/appengine/lib/impl/appengine-local-runtime.jar

A    third_party/java/appengine/lib/impl/agent

A    third_party/java/appengine/lib/impl/agent/appengine-agentruntime.jar

A    third_party/java/appengine/lib/appengine-remote-api.jar

A    third_party/java/appengine/lib/opt

A    third_party/java/appengine/lib/opt/tools

A    third_party/java/appengine/lib/opt/tools/appengine-local-endpoints

A    third_party/java/appengine/lib/opt/tools/appengine-local-endpoints/v1

A
third_party/java/appengine/lib/opt/tools/appengine-local-endpoints/v1/appengine-local-endpoints.jar

A    third_party/java/appengine/lib/opt/tools/datanucleus

A    third_party/java/appengine/lib/opt/tools/datanucleus/v1

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/datanucleus-enhancer-1.1.4.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/jdo2-api-2.3-eb.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/geronimo-jpa_3.0_spec-1.1.1.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/datanucleus-core-1.1.5.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/geronimo-jta_1.1_spec-1.1.1.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v1/datanucleus-jpa-1.1.5.jar

A    third_party/java/appengine/lib/opt/tools/datanucleus/v1/asm-4.1.jar

A    third_party/java/appengine/lib/opt/tools/datanucleus/v2

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/datanucleus-api-jpa-3.1.3.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/datanucleus-enhancer-3.1.1.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/datanucleus-api-jdo-3.1.3.jar

A    third_party/java/appengine/lib/opt/tools/datanucleus/v2/jta-1.1.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/geronimo-jpa_2.0_spec-1.0.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/datanucleus-core-3.1.3.jar

A    third_party/java/appengine/lib/opt/tools/datanucleus/v2/asm-4.0.jar

A
third_party/java/appengine/lib/opt/tools/datanucleus/v2/jdo-api-3.0.1.jar

A    third_party/java/appengine/lib/opt/user

A    third_party/java/appengine/lib/opt/user/jsr107

A    third_party/java/appengine/lib/opt/user/jsr107/v1

A    third_party/java/appengine/lib/opt/user/jsr107/v1/jsr107cache-1.1.jar

A
third_party/java/appengine/lib/opt/user/jsr107/v1/appengine-jsr107cache-1.9.0.jar

A    third_party/java/appengine/lib/opt/user/appengine-endpoints

A    third_party/java/appengine/lib/opt/user/appengine-endpoints/v1

A
third_party/java/appengine/lib/opt/user/appengine-endpoints/v1/appengine-endpoints.jar

A
third_party/java/appengine/lib/opt/user/appengine-endpoints/v1/appengine-endpoints-deps.jar

A    third_party/java/appengine/lib/opt/user/datanucleus

A    third_party/java/appengine/lib/opt/user/datanucleus/v1

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/jdo2-api-2.3-eb.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/geronimo-jpa_3.0_spec-1.1.1.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/datanucleus-core-1.1.5.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/datanucleus-appengine-1.0.10.final.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/geronimo-jta_1.1_spec-1.1.1.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v1/datanucleus-jpa-1.1.5.jar

A    third_party/java/appengine/lib/opt/user/datanucleus/v2

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/datanucleus-api-jpa-3.1.3.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/datanucleus-api-jdo-3.1.3.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/datanucleus-appengine-2.1.2.jar

A    third_party/java/appengine/lib/opt/user/datanucleus/v2/jta-1.1.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/geronimo-jpa_2.0_spec-1.0.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/datanucleus-core-3.1.3.jar

A    third_party/java/appengine/lib/opt/user/datanucleus/v2/asm-4.0.jar

A
third_party/java/appengine/lib/opt/user/datanucleus/v2/jdo-api-3.0.1.jar

A    third_party/java/appengine/lib/opt/user/appengine-api-labs

A    third_party/java/appengine/lib/opt/user/appengine-api-labs/v1

A
third_party/java/appengine/lib/opt/user/appengine-api-labs/v1/appengine-api-labs.jar

A    third_party/java/appengine/lib/appengine-tools-api.jar

A    third_party/java/appengine/lib/shared

A    third_party/java/appengine/lib/shared/el-api.jar

A    third_party/java/appengine/lib/shared/LICENSE

A    third_party/java/appengine/lib/shared/servlet-api.jar

A    third_party/java/appengine/lib/shared/jsp

A
third_party/java/appengine/lib/shared/jsp/repackaged-appengine-jasper-el-6.0.29.jar

A
third_party/java/appengine/lib/shared/jsp/repackaged-appengine-jasper-6.0.29.jar

A    third_party/java/appengine/lib/shared/jsp/LICENSE

A
third_party/java/appengine/lib/shared/jsp/repackaged-appengine-tomcat-juli-6.0.29.jar

A
third_party/java/appengine/lib/shared/jsp/repackaged-appengine-ant-launcher-1.7.1.jar

A
third_party/java/appengine/lib/shared/jsp/repackaged-appengine-ant-1.7.1.jar

A    third_party/java/appengine/lib/shared/jsp-api.jar

A
third_party/java/appengine/lib/shared/appengine-local-runtime-shared.jar

A    third_party/java/appengine/lib/testing

A    third_party/java/appengine/lib/testing/appengine-testing.jar

A    third_party/java/appengine/lib/user

A    third_party/java/appengine/lib/user/jsr107cache-1.1.jar

A    third_party/java/appengine/lib/user/libservice.jar

A    third_party/java/appengine/lib/user/appengine-api-1.0-sdk-1.9.0.jar

A    third_party/java/appengine/lib/user/appengine-api-labs-1.9.0.jar

A    third_party/java/appengine/lib/user/appengine-jsr107cache-1.9.0.jar

A    third_party/java/appengine/lib/user/orm

A    third_party/java/appengine/lib/user/orm/jdo2-api-2.3-eb.jar

A    third_party/java/appengine/lib/user/orm/geronimo-jpa_3.0_spec-1.1.1.jar

A    third_party/java/appengine/lib/user/orm/datanucleus-core-1.1.5.jar

A
third_party/java/appengine/lib/user/orm/datanucleus-appengine-1.0.10.final.jar

A    third_party/java/appengine/lib/user/orm/geronimo-jta_1.1_spec-1.1.1.jar

A    third_party/java/appengine/lib/user/orm/datanucleus-jpa-1.1.5.jar

A    third_party/java/appengine/lib/agent

A    third_party/java/appengine/lib/agent/appengine-agentimpl.jar

A    third_party/java/appengine/lib/agent/appengine-agent.jar

D    third_party/java/appengine/src

A    third_party/java/appengine/src

A    third_party/java/appengine/src/opt

A    third_party/java/appengine/src/opt/user

A    third_party/java/appengine/src/opt/user/datanucleus

A    third_party/java/appengine/src/opt/user/datanucleus/v1

A
third_party/java/appengine/src/opt/user/datanucleus/v1/datanucleus-core-1.1.5-src.zip

A
third_party/java/appengine/src/opt/user/datanucleus/v1/datanucleus-appengine-1.0.10.final-src.zip

A
third_party/java/appengine/src/opt/user/datanucleus/v1/datanucleus-jpa-1.1.5-src.zip

A
third_party/java/appengine/src/opt/user/datanucleus/v1/jdo2-api-2.3-SNAPSHOT-src.zip

A
third_party/java/appengine/src/opt/user/datanucleus/v1/datanucleus-enhancer-1.1.4-src.zip

A    third_party/java/appengine/src/opt/user/datanucleus/v2

A
third_party/java/appengine/src/opt/user/datanucleus/v2/datanucleus-api-jpa-3.1.3-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/datanucleus-enhancer-3.1.1-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/datanucleus-api-jdo-3.1.3-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/datanucleus-appengine-2.1.2-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/geronimo-jpa_2.0_spec-1.0-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/datanucleus-core-3.1.3-sources.jar

A
third_party/java/appengine/src/opt/user/datanucleus/v2/jdo-api-3.0.1-sources.jar

A    third_party/java/appengine/src/orm

A    third_party/java/appengine/src/orm/datanucleus-core-1.1.5-src.zip

A
third_party/java/appengine/src/orm/datanucleus-appengine-1.0.10.final-src.zip

A    third_party/java/appengine/src/orm/datanucleus-jpa-1.1.5-src.zip

A    third_party/java/appengine/src/orm/jdo2-api-2.3-SNAPSHOT-src.zip

A    third_party/java/appengine/src/orm/datanucleus-enhancer-1.1.4-src.zip

A    third_party/java/appengine/src/user

A    third_party/java/appengine/src/user/appengine-api-1.0-sdk-1.9.0-src.zip

D    third_party/java/appengine/bin

A    third_party/java/appengine/bin

A    third_party/java/appengine/bin/appcfg.cmd

A    third_party/java/appengine/bin/google_sql.sh

A    third_party/java/appengine/bin/endpoints.cmd

A    third_party/java/appengine/bin/dev_appserver.cmd

A    third_party/java/appengine/bin/appcfg.sh

A    third_party/java/appengine/bin/endpoints.sh

A    third_party/java/appengine/bin/google_sql.cmd

A    third_party/java/appengine/bin/dev_appserver.sh

D    third_party/java/appengine/RELEASE_NOTES

A    third_party/java/appengine/RELEASE_NOTES

D    third_party/java/appengine/COPYING

A    third_party/java/appengine/COPYING

D    third_party/java/appengine/README.ORM

A    third_party/java/appengine/README.ORM

D    third_party/java/appengine/ABOUT

A    third_party/java/appengine/ABOUT

D    third_party/java/appengine/README

A    third_party/java/appengine/README

U    web.xml

Updated to revision 5674.

[felix8a, 2014-03-17 02:21:00]

I think that means you need to update java?
On Mar 16, 2014 3:23 PM, "Mark Miller" <erights@gmail.com> wrote:

> After a "myvn up", I get the following. The "myvn up" did update a bunch
> of third_party/java/appengine/* stuff. What's the problem here, and what
> should I do to get past it?
>
>
>
> $ ant clean
>
> Buildfile: /Users/erights/svn-changes/unrepair/google-caja/build.xml
>
>
> BUILD FAILED
>
> /Users/erights/svn-changes/unrepair/google-caja/build.xml:125: The
> following error occurred while executing this line:
>
>
/Users/erights/svn-changes/unrepair/google-caja/third_party/java/appengine/config/user/ant-macros.xml:83:
> java.lang.UnsupportedClassVersionError:
> com/google/appengine/tools/enhancer/EnhancerTask : Unsupported major.minor
> version 51.0
>
> at java.lang.ClassLoader.defineClass1(Native Method)
>
> at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
>
> at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
>
> at
>
org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1128)
>
> at
>
org.apache.tools.ant.AntClassLoader.getClassFromStream(AntClassLoader.java:1299)
>
> at
>
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1354)
>
> at org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1315)
>
> at org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1068)
>
> at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
>
> at java.lang.Class.forName0(Native Method)
>
> at java.lang.Class.forName(Class.java:249)
>
> at org.apache.tools.ant.taskdefs.Definer.addDefinition(Definer.java:579)
>
> at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:237)
>
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>
> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>
> at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:597)
>
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
>
> at org.apache.tools.ant.Task.perform(Task.java:348)
>
> at org.apache.tools.ant.Target.execute(Target.java:435)
>
> at
> org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:168)
>
> at
> org.apache.tools.ant.taskdefs.ImportTask.importResource(ImportTask.java:230)
>
> at org.apache.tools.ant.taskdefs.ImportTask.execute(ImportTask.java:162)
>
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>
> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>
> at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:597)
>
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
>
> at org.apache.tools.ant.Task.perform(Task.java:348)
>
> at org.apache.tools.ant.Target.execute(Target.java:435)
>
> at
> org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:179)
>
> at
> org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:93)
>
> at org.apache.tools.ant.Main.runBuild(Main.java:826)
>
> at org.apache.tools.ant.Main.startAnt(Main.java:235)
>
> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
>
> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)
>
>
> Total time: 0 seconds
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-caja-discuss+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[Mark S. Miller, 2014-03-17 02:53:05]

That was it. Thanks.


On Sun, Mar 16, 2014 at 7:20 PM, felix <felix8a@gmail.com> wrote:

> I think that means you need to update java?
> On Mar 16, 2014 3:23 PM, "Mark Miller" <erights@gmail.com> wrote:
>
>>  After a "myvn up", I get the following. The "myvn up" did update a
>> bunch of third_party/java/appengine/* stuff. What's the problem here, and
>> what should I do to get past it?
>>
>>
>>
>> $ ant clean
>>
>> Buildfile: /Users/erights/svn-changes/unrepair/google-caja/build.xml
>>
>>
>> BUILD FAILED
>>
>> /Users/erights/svn-changes/unrepair/google-caja/build.xml:125: The
>> following error occurred while executing this line:
>>
>>
/Users/erights/svn-changes/unrepair/google-caja/third_party/java/appengine/config/user/ant-macros.xml:83:
>> java.lang.UnsupportedClassVersionError:
>> com/google/appengine/tools/enhancer/EnhancerTask : Unsupported major.minor
>> version 51.0
>>
>> at java.lang.ClassLoader.defineClass1(Native Method)
>>
>> at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
>>
>> at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
>>
>> at
>>
org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1128)
>>
>> at
>>
org.apache.tools.ant.AntClassLoader.getClassFromStream(AntClassLoader.java:1299)
>>
>> at
>>
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1354)
>>
>> at org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1315)
>>
>> at org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1068)
>>
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
>>
>> at java.lang.Class.forName0(Native Method)
>>
>> at java.lang.Class.forName(Class.java:249)
>>
>> at org.apache.tools.ant.taskdefs.Definer.addDefinition(Definer.java:579)
>>
>> at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:237)
>>
>> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>
>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>>
>> at
>>
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>
>> at java.lang.reflect.Method.invoke(Method.java:597)
>>
>> at
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
>>
>> at org.apache.tools.ant.Task.perform(Task.java:348)
>>
>> at org.apache.tools.ant.Target.execute(Target.java:435)
>>
>> at
>> org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:168)
>>
>> at
>> org.apache.tools.ant.taskdefs.ImportTask.importResource(ImportTask.java:230)
>>
>> at org.apache.tools.ant.taskdefs.ImportTask.execute(ImportTask.java:162)
>>
>> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>
>> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>>
>> at
>>
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>
>> at java.lang.reflect.Method.invoke(Method.java:597)
>>
>> at
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
>>
>> at org.apache.tools.ant.Task.perform(Task.java:348)
>>
>> at org.apache.tools.ant.Target.execute(Target.java:435)
>>
>> at
>> org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:179)
>>
>> at
>> org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:93)
>>
>> at org.apache.tools.ant.Main.runBuild(Main.java:826)
>>
>> at org.apache.tools.ant.Main.startAnt(Main.java:235)
>>
>> at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
>>
>> at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)
>>
>>
>> Total time: 0 seconds
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Google Caja Discuss" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-caja-discuss+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>  --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-caja-discuss+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
    Cheers,
    --MarkM