Issue 6769043: Protect filter_texture() against render target change.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6769043: Protect filter_texture() against render target change. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Stephen White

Modified:
11 years, 11 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Protect filter_texture() against render target change. Fix blend filters when input textures are "sloppy" (approx scratch texture match) Add a new test case to gm/imagefiltersgraph, and reduce its size. NOTE: this will require new baselines for the imagefiltersgraph GM. BUG=950 Committed: https://code.google.com/p/skia/source/detail?r=6073

Patch Set 1 #

Patch Set 2 : Fix line length. #

Patch Set 3 : Use AutoWideOpenIdentityDraw instead of AutoRenderTarget. #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -15 lines)			Patch
M	gm/imagefiltersgraph.cpp	View		3 chunks	+29 lines, -11 lines	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

11 years, 11 months ago (2012-10-24 15:01:58 UTC) #2

On 2012/10/24 14:50:25, Stephen White wrote:
> PTAL

LGTM w/ discussed change to set NULL rather than context->rt().

Expand All Messages | Collapse All Messages