Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2623)

Issue 6767053: cmd/jujud: agent should perform one cycle (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dave
Modified:
11 years, 6 months ago
Reviewers:
mp+131369, fwereade, niemeyer
Visibility:
Public.

Description

cmd/jujud: agent should perform one cycle Fixes #1068445. This proposal alters the logic on the unit and machine agents to perform at least one cycle before checking the tomb value. This change is important as our tests start an agent with a runStop() method, who's intention is to run the agent for a short period of time to exercise one aspect of its behavior. The difficulty is runStop() can put the tomb into a Dying state before the agent has started, causing it to exit immediately without taking any action. https://code.launchpad.net/~dave-cheney/juju-core/026-uniter-failure/+merge/131369 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: agent should perform one cycle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 2 chunks +3 lines, -1 line 0 comments Download
M cmd/jujud/unit.go View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-10-25 10:31:13 UTC) #1
fwereade
LGTM
11 years, 6 months ago (2012-10-25 14:55:38 UTC) #2
niemeyer
The description says what this is doing, but it doesn't say why. It's quite probably ...
11 years, 6 months ago (2012-10-29 10:21:02 UTC) #3
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-10-29 16:06:19 UTC) #4
dave_cheney.net
PTAL, i have updated the description to better describe the problem and the proposed solution.
11 years, 6 months ago (2012-10-29 16:06:33 UTC) #5
niemeyer
11 years, 6 months ago (2012-10-30 08:22:11 UTC) #6
Thanks. We discussed a slightly different approach to reach the same result (and
fix runStop, which is quite broken ATM).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b