Issue 6752044: Make GrGLProgram be responsible for calling setData on custom stages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6752044: Make GrGLProgram be responsible for calling setData on custom stages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bsalomon

Modified:
12 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrGLProgram be responsible for calling setData on custom stages. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6027

Patch Set 1 #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -20 lines)			Patch
M	src/gpu/gl/GrGLProgram.h	View	6 chunks	+11 lines, -13 lines	2 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6752044/diff/1/src/gpu/gl/GrGLProgram.h File src/gpu/gl/GrGLProgram.h (left): https://codereview.appspot.com/6752044/diff/1/src/gpu/gl/GrGLProgram.h#oldcode71 src/gpu/gl/GrGLProgram.h:71: static int ViewMatrixAttributeIdx() { These were no longer being ...

12 years ago (2012-10-22 14:04:56 UTC) #1

LGTM

Expand All Messages | Collapse All Messages