Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119)

Issue 6750057: Script to archive or replay webpages, generate skp files and store both in Google Storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by rmistry
Modified:
12 years, 8 months ago
Reviewers:
epoger, EricB
CC:
skia-review_googlegroups.com, skiabot_google.com
Base URL:
http://skia.googlecode.com/svn/buildbot/
Visibility:
Public.

Description

Script to archive or replay webpages, generate skp files and store both in Google Storage. The intent is for webpages to be archived and stored along with GM skp files rarely (maybe once a month or once every 3 months). The archived webpages will be replayed and skp files generated per revision. This changeset has been created to fix the following feature requests- http://code.google.com/p/skia/issues/detail?id=883 : create system to capture HTML source of popular web sites for SkPicture testing. http://code.google.com/p/skia/issues/detail?id=884 : create semi-automated system to generate SkPicture files from captured HTML source. Committed: https://code.google.com/p/skia/source/detail?r=6204

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 6

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -1 line) Patch
M DEPS View 1 2 3 4 5 6 7 1 chunk +19 lines, -1 line 0 comments Download
A slave/skia_slave_scripts/skpicture_playback/webpages_playback.py View 1 2 3 4 5 6 1 chunk +180 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rmistry
12 years, 8 months ago (2012-10-23 15:29:35 UTC) #1
rmistry
Updated the chromium_revision at Patch Set 4 to include https://codereview.chromium.org/11189123
12 years, 8 months ago (2012-10-24 11:51:31 UTC) #2
rmistry
On 2012/10/24 11:51:31, rmistry wrote: > Updated the chromium_revision at Patch Set 4 to include ...
12 years, 8 months ago (2012-10-24 13:29:20 UTC) #3
rmistry
Patch Set 7 contains a big refactoring that changed the script to support the case ...
12 years, 8 months ago (2012-10-26 19:09:50 UTC) #4
epoger
Eric, I'm gonna let you review this one first. Let me know if that's problematic, ...
12 years, 8 months ago (2012-10-29 16:51:35 UTC) #5
EricB
LGTM with comment/question. https://codereview.appspot.com/6750057/diff/14001/slave/skia_slave_scripts/skpicture_playback/webpages_playback.py File slave/skia_slave_scripts/skpicture_playback/webpages_playback.py (right): https://codereview.appspot.com/6750057/diff/14001/slave/skia_slave_scripts/skpicture_playback/webpages_playback.py#newcode85 slave/skia_slave_scripts/skpicture_playback/webpages_playback.py:85: multipage_benchmark_runner.Main() Modifying sys.argv and calling Main() ...
12 years, 8 months ago (2012-10-29 17:26:51 UTC) #6
epoger
LGTM https://codereview.appspot.com/6750057/diff/14001/DEPS File DEPS (right): https://codereview.appspot.com/6750057/diff/14001/DEPS#newcode30 DEPS:30: # build/android/pylib/android_commands.py requires android_testrunner to be in third_party. ...
12 years, 8 months ago (2012-10-30 14:32:31 UTC) #7
epoger
On 2012/10/30 14:32:31, epoger wrote: > LGTM not that you need my LGTM, since you ...
12 years, 8 months ago (2012-10-30 14:33:02 UTC) #8
rmistry
12 years, 8 months ago (2012-10-30 17:17:19 UTC) #9
https://codereview.appspot.com/6750057/diff/14001/DEPS
File DEPS (right):

https://codereview.appspot.com/6750057/diff/14001/DEPS#newcode30
DEPS:30: # build/android/pylib/android_commands.py requires android_testrunner
to be in third_party.
On 2012/10/30 14:32:31, epoger wrote:
> maybe add a blank line before this one

Done.

https://codereview.appspot.com/6750057/diff/14001/DEPS#newcode33
DEPS:33: # chrome_remote_control/replay_server.py requires webpagereplay to be
in src/third_party.
On 2012/10/30 14:32:31, epoger wrote:
> maybe add a blank line before this one

Done.

https://codereview.appspot.com/6750057/diff/14001/slave/skia_slave_scripts/sk...
File slave/skia_slave_scripts/skpicture_playback/webpages_playback.py (right):

https://codereview.appspot.com/6750057/diff/14001/slave/skia_slave_scripts/sk...
slave/skia_slave_scripts/skpicture_playback/webpages_playback.py:85:
multipage_benchmark_runner.Main()
On 2012/10/29 17:26:52, EricB wrote:
> Modifying sys.argv and calling Main() seems like a strange way to invoke this
> script.  I guess there isn't a good way around it since the script comes from
> upstream?

Yes, unfortunately this is the best way I found of invoking
multipage_benchmark_runner.py
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b