Issue 6749067: clarify code/comments in gmmain.cpp (no functional change)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6749067: clarify code/comments in gmmain.cpp (no functional change) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by epoger

Modified:
11 years, 10 months ago

Reviewers:
edisonn, Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

clarify code/comments in gmmain.cpp (no functional change) Committed: https://code.google.com/p/skia/source/detail?r=6115

Patch Set 1 #

Total comments: 2

Patch Set 2 : rewrap_lines #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -35 lines)			Patch
	M	gm/gmmain.cpp	View	1	19 chunks	+64 lines, -35 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

I started working on substantial changes to gmmain.cpp for https://goto.google.com/ImprovingTheSkiaRebaseliningProcess , but along the way ...

11 years, 10 months ago (2012-10-23 19:54:17 UTC) #1

edisonn

11 years, 10 months ago (2012-10-23 21:14:45 UTC) #3

LGTM
nice comments. Can I claim victory and disqualify the first competitor?

https://codereview.appspot.com/6749067/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.appspot.com/6749067/diff/1/gm/gmmain.cpp#newcode696
gm/gmmain.cpp:696: string.c_str(), bitmap, NULL, &referenceBitmap);
neat: align and line break

https://codereview.appspot.com/6749067/diff/1/gm/gmmain.cpp#newcode727
gm/gmmain.cpp:727: string.c_str(), bitmap, NULL, &referenceBitmap);
line break

Expand All Messages | Collapse All Messages