Added ability to extract SkBitmaps to filter tool

I found this useful when trying to investigate skp performance.

[DerekS, 2012-10-19 12:14:10]

https://codereview.appspot.com/6748043/diff/1/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

https://codereview.appspot.com/6748043/diff/1/src/core/SkPictureRecord.h#newc...
src/core/SkPictureRecord.h:176: SkBitmapHeap* fBitmapHeap;
this makes it appear like it's part of the previous comment which isn't true as
this is not set to NULL.

https://codereview.appspot.com/6748043/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6748043/diff/1/tools/filtermain.cpp#newcode33
tools/filtermain.cpp:33: SkTRefArray<SkBitmap>* bitmaps =
fBitmapHeap->extractBitmaps();
if all you need it for is extracting bitmaps. I think it may be better to just
expose that function as a public method on SkPictureRecord.

SkPictureRecord::extractImages()

[robertphillips, 2012-10-19 15:47:34]

https://codereview.appspot.com/6748043/diff/1/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

https://codereview.appspot.com/6748043/diff/1/src/core/SkPictureRecord.h#newc...
src/core/SkPictureRecord.h:176: SkBitmapHeap* fBitmapHeap;
On 2012/10/19 12:14:10, DerekS wrote:
> this makes it appear like it's part of the previous comment which isn't true
as
> this is not set to NULL.

Done.

https://codereview.appspot.com/6748043/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6748043/diff/1/tools/filtermain.cpp#newcode33
tools/filtermain.cpp:33: SkTRefArray<SkBitmap>* bitmaps =
fBitmapHeap->extractBitmaps();
This tool (the filter) is meant to provide a place where potential peep-hole
optimizations can be worked out and applied to the existing .skp files. The
SkFilterRecord class is a big part of that and will need to grow to allow
additional manipulation of the SkPicture elements.

My first attempt at this CL did add a new entry point to access the textures but
I felt, since we would need SkFilterRecord anyway, this would be a minimally
invasive way to effect this change.

[DerekS, 2012-10-19 18:51:37]

lgtm with some nits

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode21
tools/filtermain.cpp:21: SkDebugf("    -p pictureDir : directory in which to
place textures.\n");
pictureDir is where we put textures?

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode30
tools/filtermain.cpp:30: }
missing space

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode37
tools/filtermain.cpp:37: const SkBitmap& bm = bitmaps->at(i);
remove me

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode47
tools/filtermain.cpp:47: SkImageEncoder::EncodeFile(filename.c_str(), bm,
bm[i]

[robertphillips, 2012-10-19 19:06:44]

committed as r6021

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode21
tools/filtermain.cpp:21: SkDebugf("    -p pictureDir : directory in which to
place textures.\n");
On 2012/10/19 18:51:37, DerekS wrote:
> pictureDir is where we put textures?

Done.

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode30
tools/filtermain.cpp:30: }
On 2012/10/19 18:51:37, DerekS wrote:
> missing space

Done.

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode37
tools/filtermain.cpp:37: const SkBitmap& bm = bitmaps->at(i);
On 2012/10/19 18:51:37, DerekS wrote:
> remove me

Done.

https://codereview.appspot.com/6748043/diff/6001/tools/filtermain.cpp#newcode47
tools/filtermain.cpp:47: SkImageEncoder::EncodeFile(filename.c_str(), bm,
On 2012/10/19 18:51:37, DerekS wrote:
> bm[i]

Done.