Issue 6745046: Move SplitBlockAndInsertIfThen to BasicBlockUtils.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by eugenis

Modified:
12 years, 3 months ago

Reviewers:
kcc2

Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 3 : . #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -35 lines)			Patch
M	include/llvm/Transforms/Utils/BasicBlockUtils.h	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	lib/Transforms/Instrumentation/AddressSanitizer.cpp	View		4 chunks	+4 lines, -35 lines	0 comments	Download
M	lib/Transforms/Utils/BasicBlockUtils.cpp	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kcc2

https://codereview.appspot.com/6745046/diff/1/include/llvm/Transforms/Utils/BasicBlockUtils.h File include/llvm/Transforms/Utils/BasicBlockUtils.h (right): https://codereview.appspot.com/6745046/diff/1/include/llvm/Transforms/Utils/BasicBlockUtils.h#newcode211 include/llvm/Transforms/Utils/BasicBlockUtils.h:211: /// new block. The two blocks are connected by ...

12 years, 3 months ago (2012-10-19 10:30:10 UTC) #1

eugenis

12 years, 3 months ago (2012-10-19 10:34:00 UTC) #2

kcc2

LGTM https://codereview.appspot.com/6745046/diff/4001/lib/Transforms/Utils/BasicBlockUtils.cpp File lib/Transforms/Utils/BasicBlockUtils.cpp (right): https://codereview.appspot.com/6745046/diff/4001/lib/Transforms/Utils/BasicBlockUtils.cpp#newcode693 lib/Transforms/Utils/BasicBlockUtils.cpp:693: /// new block. The two blocks are connected ...

12 years, 3 months ago (2012-10-19 10:36:23 UTC) #3

eugenis

12 years, 3 months ago (2012-10-19 10:37:39 UTC) #4

https://codereview.appspot.com/6745046/diff/4001/lib/Transforms/Utils/BasicBl...
File lib/Transforms/Utils/BasicBlockUtils.cpp (right):

https://codereview.appspot.com/6745046/diff/4001/lib/Transforms/Utils/BasicBl...
lib/Transforms/Utils/BasicBlockUtils.cpp:693: /// new block. The two blocks are
connected by an conditional branch
On 2012/10/19 10:36:23, kcc2 wrote:
> here too: an => a

Done.

Expand All Messages | Collapse All Messages