Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1165)

Issue 6744068: Support blank iframe contentDocument/contentWindow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by kpreid2
Modified:
1 year, 5 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Guest code can now access the contentDocument of an iframe. Loading a
document into an iframe (with iframe src= or contentWindow.location)
is still not supported.

Includes support for Domado virtual documents rooted at real document
nodes; however, since the HTML schema is written for the usual case, we
still have to virtualize the HTML global structure (<caja-v-html> etc);
this has not yet had any detectable negative effects.

Improves jQuery test suite compatibility.

@r5151

Patch Set 1 #

Total comments: 4

Patch Set 2 : Support blank iframe contentDocument/contentWindow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -23 lines) Patch
M src/com/google/caja/plugin/bridal.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 6 chunks +68 lines, -10 lines 0 comments Download
M tests/com/google/caja/plugin/JQueryTest.java View 1 7 chunks +10 lines, -11 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kpreid2
1 year, 6 months ago #1
felix8a
I'm very wary of this. You're making a new domicile for each tame iframe, and ...
1 year, 6 months ago #2
kpreid2
On 2012/10/23 21:38:28, felix8a wrote: > I'm very wary of this. Me too, in general ...
1 year, 6 months ago #3
felix8a
1 year, 5 months ago #4
lgtm.  I've convinced myself this is harmless.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5